hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-619) Unify Map-Reduce and Streaming to take the same globbed input specification
Date Mon, 18 Dec 2006 20:48:24 GMT
     [ http://issues.apache.org/jira/browse/HADOOP-619?page=all ]

Doug Cutting updated HADOOP-619:
--------------------------------

    Status: Open  (was: Patch Available)

+      String filename = filePattern.toString();
+      int schemeIdx = filename.lastIndexOf(':');
+      // remove scheme/server/port from path for glob match
+      if( -1 != schemeIdx ){
+        filename = filename.substring(
+            filename.indexOf(Path.SEPARATOR_CHAR, schemeIdx));
+      }

This should not be a string manipulation, but rather use the Path's URI, e.g. simply:

String filename = filePattern.toUri().getPath();

The spacing in this patch is also unusual.

http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#682



> Unify Map-Reduce and Streaming to take the same globbed input specification
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-619
>                 URL: http://issues.apache.org/jira/browse/HADOOP-619
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.9.1
>            Reporter: eric baldeschwieler
>         Assigned To: Sanjay Dahiya
>             Fix For: 0.10.0
>
>         Attachments: Hadoop-619.patch, Hadoop-619.patch, Hadoop-619.patch, Hadoop-619_1.patch,
Hadoop-619_1.patch, Hadoop-619_2.patch
>
>
> Right now streaming input is specified very differently from other map-reduce input.
 It would be good if these two apps could take much more similar input specs.
> In particular -input in streaming expects a file or glob pattern while MR takes a directory.
 It would be cool if both could take a glob patern of files and if both took a directory by
default (with some patern excluded to allow logs, metadata and other framework output to be
safely stored).
> We want to be sure that MR input is backward compatible over this change.  I propose
that a single file should be accepted as an input or a single directory.  Globs should only
match directories if the paterns is '/' terminated, to avoid massive inputs specified by mistake.
> Thoughts?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message