Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 23150 invoked from network); 28 Nov 2006 07:26:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Nov 2006 07:26:45 -0000 Received: (qmail 30824 invoked by uid 500); 28 Nov 2006 07:26:53 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 30790 invoked by uid 500); 28 Nov 2006 07:26:53 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 30781 invoked by uid 99); 28 Nov 2006 07:26:53 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Nov 2006 23:26:53 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Nov 2006 23:26:43 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 35A527142F3 for ; Mon, 27 Nov 2006 23:26:23 -0800 (PST) Message-ID: <26298023.1164698783216.JavaMail.jira@brutus> Date: Mon, 27 Nov 2006 23:26:23 -0800 (PST) From: "Hadoop QA (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-698) When DFS client fails to read from a datanode, the failed datanode is not excluded from target reselection In-Reply-To: <17466448.1163027091463.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/HADOOP-698?page=comments#action_12453815 ] Hadoop QA commented on HADOOP-698: ---------------------------------- +1, http://issues.apache.org/jira/secure/attachment/12345881/datanode-exclude.patch applied and successfully tested against trunk revision 479931 > When DFS client fails to read from a datanode, the failed datanode is not excluded from target reselection > ---------------------------------------------------------------------------------------------------------- > > Key: HADOOP-698 > URL: http://issues.apache.org/jira/browse/HADOOP-698 > Project: Hadoop > Issue Type: Bug > Components: dfs > Reporter: Hairong Kuang > Assigned To: Milind Bhandarkar > Attachments: datanode-exclude.patch > > > In the method read(byte buf[ ], int off, int len) of DFSInputStream, when read fails, it calls "blockSeekTo" to reselect a datanode. However, the failed datanode does not feed back to blockSeekTo. The datanode selection algorithm works as follows: > * If the machine that the client is running on has a local copy, return the local machine; > * Otherwise, randomly pick up one location. > When the failed data node info does not feed back to target reselection, this leads to two flaws: > 1. When a client fails to read from the local copy, for example, because of the checksum error, the local machine will always be chosen in retries. > 2. Random selection may still return the same failed node. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira