hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-639) task cleanup messages can get lost, causing task trackers to keep tasks forever
Date Wed, 29 Nov 2006 19:11:22 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-639?page=comments#action_12454414 ] 
            
Doug Cutting commented on HADOOP-639:
-------------------------------------

The new protocol method signature is inconsistent:

public HeartbeatResponse updateStatus(TaskTrackerStatus status, boolean);

Everyone refers to this as the heartbeat, why not still call it that?

public HeartBeatResponse heartbeat(TaskTrackerStatus status, boolean);

Either that, or completely remove 'heartbeat' from our vocabulary.  Personally, I prefer using
heartbeat consistently for this, but I wouldn't reject this patch over that.  I feel more
strongly however that the naming should be consistent.  We shouldn't call it a heartbeat response
unless it's a response to something we call a heartbeat.

> task cleanup messages can get lost, causing task trackers to keep tasks forever
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-639
>                 URL: http://issues.apache.org/jira/browse/HADOOP-639
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.7.2
>            Reporter: Owen O'Malley
>         Assigned To: Arun C Murthy
>             Fix For: 0.9.0
>
>         Attachments: HADOOP-639_1.patch
>
>
> If the pollForTaskWithClosedJob call from a job tracker to a task tracker times out when
a job completes, the tasks are never cleaned up. This can cause the mini m/r cluster to hang
on shutdown, but also is a resource leak.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message