hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-611) SequenceFile.Sorter should have a merge method that returns an iterator
Date Wed, 08 Nov 2006 18:14:54 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-611?page=comments#action_12448220 ] 
            
Owen O'Malley commented on HADOOP-611:
--------------------------------------

I don't understand the ignoreSync, doSync code that you have in the the SegmentDescriptor.
You should never set the sync = null on a Reader. It is done on merge outputs via writer.sync
= null to keep the writer from putting in sync blocks, which wastes space since the merge
outputs won't be split as map inputs. But setting sync = null on a reader shouldn't be necessary.

> SequenceFile.Sorter should have a merge method that returns an iterator
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-611
>                 URL: http://issues.apache.org/jira/browse/HADOOP-611
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: io
>            Reporter: Owen O'Malley
>         Assigned To: Devaraj Das
>             Fix For: 0.9.0
>
>         Attachments: merge.patch, merge.patch, merge.patch, merge.patch
>
>
> SequenceFile.Sorter should get a new merge method that returns an iterator over the keys/values.
> The current merge method should become a simple method that gets the iterator and writes
the records out to a file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message