hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-567) The build script should record the Hadoop version into the build
Date Mon, 02 Oct 2006 19:01:21 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-567?page=comments#action_12439273 ] 
            
Doug Cutting commented on HADOOP-567:
-------------------------------------

This is very cool!  +1

A few naming nits.  The script name should end with '.sh'.  And the field names in the generated
class are 'static final' and hence their names should be all caps.  It would also be good
to get some javadoc in that class.  And instead of BuildStamp, we might just call this Version
or HadoopVersion, no?

Finally, I'm not sure why util.VersionInfo is needed.  Under what situations is this better
than simply referencing the constants in the generated class?

Lucene does something related with:

http://lucene.apache.org/java/docs/api/org/apache/lucene/LucenePackage.html

The version is built into the jar manifest in the jar-core target of:

http://svn.apache.org/viewvc/lucene/java/trunk/common-build.xml?view=markup

Then it's accessed with:

http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/LucenePackage.java?view=markup

This does not have the subversion revision, which would be really nice.  Also, in addition
to the revision, it would be good to have the repository URL.  Then one could always recreate
the sources.

Do you think there'd be much of an advantage to use Java's Package stuff for this?

> The build script should record the Hadoop version into the build
> ----------------------------------------------------------------
>
>                 Key: HADOOP-567
>                 URL: http://issues.apache.org/jira/browse/HADOOP-567
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: util
>    Affects Versions: 0.6.2
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.7.0
>
>         Attachments: version.patch
>
>
> It would be good to compile the Hadoop version, subversion revision, and compilation
date into the hadoop.jar file. 
> The web/ui would display the version for each of the server home page.
> I'd also add "bin/hadoop version" to print the version information.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message