hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-263) task status should include timestamps for when a job transitions
Date Fri, 22 Sep 2006 16:41:23 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-263?page=comments#action_12436903 ] 
            
Owen O'Malley commented on HADOOP-263:
--------------------------------------

As of HADOOP-306, we can put enum types into RPC and your change would be much cleaner if
the TaskUmbilicalProtocol.progress' phase parameter was really passed as an enum.

Furthermore, we should probably make methods in WritableUtils for reading and writing enums:

  public static <T extends Enum<T>> T readEnum(DataInput in, Class<T> enumType
                                                                                         )
throws IOException;
  public static void writeEnum(DataOutput out,  Enum enum) throws IOException;

The Phase field of Task should be private.

You can pull the replicated code for setting the phase out of the constructors and do:

class ReduceTask ...
  {
    setPhase(Phase.SHUFFLE); 
  }

  public ReduceTask() {
    ...
  }

  public ReduceTask(...) {
    ...
  }

the same can be done for MapTask.


> task status should include timestamps for when a job transitions
> ----------------------------------------------------------------
>
>                 Key: HADOOP-263
>                 URL: http://issues.apache.org/jira/browse/HADOOP-263
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.2.1
>            Reporter: Owen O'Malley
>         Assigned To: Sanjay Dahiya
>         Attachments: Hadoop-263.patch, Hadoop-263_1.patch, Hadoop-263_2.patch, Hadoop-263_3.patch,
Hadoop-263_4.patch, patch.txt, patch.txt, patch.txt, patch.txt
>
>
> It would help users to understand what happened if the task status included information
about when the task transitioned:
> Map:
>    started
>    finished
> Reduce:
>    started
>    shuffle finished
>    sort finished
>    finished

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message