hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-263) task status should include timestamps for when a job transitions
Date Tue, 22 Aug 2006 22:22:16 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-263?page=comments#action_12429824 ] 
            
Owen O'Malley commented on HADOOP-263:
--------------------------------------

Ok, looking at the current patch, I have a couple of comments:
  1. The shuffle & sort times should be set to the current time when a later stage is
finished. (This would happen when the shuffle or sort finishes in less than a single reporting
cycle.) I'd probably put the relevant check/update in the setters for the times in TaskStatus.
  2. You need to pull the replicated code for formatting delta times into StringUtils. And
if a field (and all of the larger fields) are 0, you shouldn't print the label except for
the last one. (eg. 0 time => "0 secs")
  3. Reporting time to milliseconds when the real granularity is 10 seconds is overkill. Just
report to seconds.
  4. You don't need to add the type parameter to the taskdetails.jsp because it is available
in TaskStatus.getIsMap()
  5. You should probably add the times to the TaskReport constructor rather than creating
the object and setting it to be consistent with the other fields.

> task status should include timestamps for when a job transitions
> ----------------------------------------------------------------
>
>                 Key: HADOOP-263
>                 URL: http://issues.apache.org/jira/browse/HADOOP-263
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.2.1
>            Reporter: Owen O'Malley
>         Assigned To: Sanjay Dahiya
>             Fix For: 0.6.0
>
>         Attachments: patch.txt, patch.txt, patch.txt, patch.txt
>
>
> It would help users to understand what happened if the task status included information
about when the task transitioned:
> Map:
>    started
>    finished
> Reduce:
>    started
>    shuffle finished
>    sort finished
>    finished

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message