hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-415) DFSNodesStatus() should sort data nodes.
Date Wed, 02 Aug 2006 22:48:14 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-415?page=comments#action_12425393 ] 
            
Konstantin Shvachko commented on HADOOP-415:
--------------------------------------------

Actually, I think that it would be even better to make DFSNodesStatus() a member of the JspHelper
 class.
And sorting should be called directly in the jsp file.
In general it would be good to keep all data collection/processing in the JspHelper class,
and let the jsp-files just output information.

> DFSNodesStatus() should sort data nodes.
> ----------------------------------------
>
>                 Key: HADOOP-415
>                 URL: http://issues.apache.org/jira/browse/HADOOP-415
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.4.0
>            Reporter: Konstantin Shvachko
>             Fix For: 0.5.0
>
>
> HADOOP-392 introduced a new TreeMap member (datanodeMapByName) in the name node.
> It is used solely for reporting the data nodes in the UI sorted by their names.
> I think it is quite inefficient both time and space-wise to support an excessive
> data structure just for that.
> Suppose the UI will also require sorting by last heartbeat and/or by the available space....
> I think DFSNodesStatus() should just sort the original datanodeMap before returning the
list.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message