hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Runping Qi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-450) Remove the need for users to specify the types of the inputs
Date Tue, 15 Aug 2006 01:01:14 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-450?page=comments#action_12427998 ] 
            
Runping Qi commented on HADOOP-450:
-----------------------------------


I don't really object to add creatKey/Value methods to RecordReader. One way or another is
fine. To add these methods, the RecordReader class needs to introduce a reference to conf
object, which Owen did, and it is just fine.

I agree we should have a separate patch for Issue 372. With the patch for Issue 450, the patch
for Issue 372 will be very simple.
If no body is working on Issue 372, I'd be happy to provide a patch for it.



> Remove the need for users to specify the types of the inputs
> ------------------------------------------------------------
>
>                 Key: HADOOP-450
>                 URL: http://issues.apache.org/jira/browse/HADOOP-450
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.5.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.6.0
>
>         Attachments: no-input-type.patch
>
>
> Currently, the application specifies the types of the input keys and values and the RecordReader
checks them for consistency. It would make more sense to have the RecordReader define the
types of keys that it will produce. Therefore, I propose that we add two new methods to RecordReader:
> WritableComparable createKey();
> Writable createValue();
> Note that I propose adding them to the RecordReader rather than the InputFormat, so that
they can specific to a particular input split.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message