hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-335) factor out the namespace image/transaction log writing
Date Sat, 15 Jul 2006 05:25:15 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-335?page=comments#action_12421272 ] 
            
Konstantin Shvachko commented on HADOOP-335:
--------------------------------------------

Sorry, this probably needed more explanation than I provided.
This is a pure refactoring patch. It does not introduce new
functionality, or improve performance, or fix a bug. The idea is to
make the code modular, easy to understand, and simplify further
modifications. So restyling seems rather appropriate in the case.
Besides, I restyle only the parts that I change. I find it reasonable
to stick to the same style at least within the same method.
I believe this patch does a minimal modification to the existing code
that achieves the goal stated by Owen in the initial comment to the issue.
Doug, I do not know what tools you use to evaluate patches.
Does it provide "ignore white spaces" option? That usually helps to
distinguish real changes from restyling.
>From your comment I did not realize is there anything I need to
change in my code, please clarify.


> factor out the namespace image/transaction log writing
> ------------------------------------------------------
>
>                 Key: HADOOP-335
>                 URL: http://issues.apache.org/jira/browse/HADOOP-335
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>         Assigned To: Konstantin Shvachko
>         Attachments: FSImage_Refactor1.patch
>
>
> Factor the checkpoint/transaction log handling code out of FSNameSystem into its own
class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message