hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-344) TaskTracker passes incorrect file path to DF under cygwin
Date Mon, 24 Jul 2006 21:58:14 GMT
     [ http://issues.apache.org/jira/browse/HADOOP-344?page=all ]

Konstantin Shvachko updated HADOOP-344:
---------------------------------------

    Attachment: DFConstructor.patch

I did two variants.
- DFConstructor.patch converts path to the canonical form inside the DF constructor.
I also changed FSDataset() to just simply return the path without canonicalizing it.
- DFPath2File.patch changes the path parameter type from String to File.
I String version constructors are deprecated.
I like this version better for 2 reasons: it makes it clear for the callers what needs to
be passed, and it does less File to String conversions.


> TaskTracker passes incorrect file path to DF under cygwin
> ---------------------------------------------------------
>
>                 Key: HADOOP-344
>                 URL: http://issues.apache.org/jira/browse/HADOOP-344
>             Project: Hadoop
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>         Environment: Windows
>            Reporter: Konstantin Shvachko
>         Assigned To: Konstantin Shvachko
>         Attachments: DFConstructor.patch, TaskTrackerDF.patch
>
>
> The path that is passed is OS dependent. The File abstraction should be used in order
to make it universal.
> I'm attaching a patch that does that.
> We might want to change the path parameter for DF. Making it File rather than String
should prevent us from 
> bugs like that in the future.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message