hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-237) Standard set of Performance Metrics for Hadoop
Date Wed, 19 Jul 2006 08:57:15 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-237?page=comments#action_12422058 ] 
            
Doug Cutting commented on HADOOP-237:
-------------------------------------

Milind, sorry to be a stickler here, but I think this still needs a bit more work.

The MetricsUtil class should be in the metrics package and just be named Metrics.  The create()
method should be renamed createRecord(). This would make canonical use look something like:

MetricsRecord record = Metrics.createRecord("dfs", "datanode");
...
Metrics.report(record, "bytes-read", bytesRead);

Also, the javadoc in this class should be improved.  It should reference the (very good) javadoc
of MetricsRecord, MetricsContext, etc.  This will be most folks first point of contact with
the metrics package.  Parameters and return types should be well documented (you can mostly
cut and paste these from MetricsRecord).

> Standard set of Performance Metrics for Hadoop
> ----------------------------------------------
>
>                 Key: HADOOP-237
>                 URL: http://issues.apache.org/jira/browse/HADOOP-237
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.3.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>         Assigned To: Milind Bhandarkar
>         Attachments: hadoop-metrics.patch
>
>
> I am starting to use Hadoop's shiny new Metrics API to publish performance (and other)
Metrics of running jobs and other daemons.
> Which performance metrics are people interested in seeing ? If possible, please group
them according to modules, such as map-reduce, dfs, general-cluster-related etc. I will follow
this process:
> 1. collect this list
> 2. assess feasibility of obtaining metric
> 3. assign context/record/metrics names
> 4. seek approval for names
> 5. instrument the code.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message