hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-321) DatanodeInfo refactoring
Date Fri, 07 Jul 2006 02:20:30 GMT
     [ http://issues.apache.org/jira/browse/HADOOP-321?page=all ]

Konstantin Shvachko updated HADOOP-321:

    Attachment: DatanodeInfo_refactor4-comp.patch

It took me a while to implement the composition approach.
But here it is. What I don't like about it is:
a) the patch is bigger (41K vs 54), and it's not just more changes
b) it's also the performance, I have to use 2 function calls instead of one,
whenever a member is accessed, but copying arrays just to obtain the inner
classes is what makes me really sad.
The latter can be avoided but will require even more changes.
I think it's not reasonable to spend more time on this issue.
Both versions are fully functional, let's pick one and move on.

> DatanodeInfo refactoring
> ------------------------
>          Key: HADOOP-321
>          URL: http://issues.apache.org/jira/browse/HADOOP-321
>      Project: Hadoop
>         Type: Improvement

>   Components: dfs
>     Reporter: Konstantin Shvachko
>     Assignee: Konstantin Shvachko
>      Fix For: 0.5.0
>  Attachments: DatanodeInfo_refactor.patch, DatanodeInfo_refactor3.patch, DatanodeInfo_refactor4-comp.patch,
> I'm trying to refactor some name node classes, which seem to be similar.
> So DatanodeInfo is a public api now for purely external ( to name node) use.
> The name node class that stores information about data nodes including the
> set of its blocks is called DatanodeDescriptor.
> The DatanodeReport is removed since it was a variation of DatanodeInfo.
> Previously DatanodeInfo and DatanodeDescriptor were the same class, and
> DatanodeReport was used for reporting node statistics only.
> This is a preparation step for HADOOP-306.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message