Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 23952 invoked from network); 14 Jun 2006 06:33:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Jun 2006 06:33:44 -0000 Received: (qmail 54721 invoked by uid 500); 14 Jun 2006 06:33:44 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 54691 invoked by uid 500); 14 Jun 2006 06:33:44 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 54682 invoked by uid 99); 14 Jun 2006 06:33:44 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jun 2006 23:33:44 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jun 2006 23:33:43 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 0E83E714204 for ; Wed, 14 Jun 2006 06:32:31 +0000 (GMT) Message-ID: <2885517.1150266751056.JavaMail.jira@brutus> Date: Wed, 14 Jun 2006 06:32:31 +0000 (GMT+00:00) From: "Owen O'Malley (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Updated: (HADOOP-135) Potential deadlock in JobTracker. In-Reply-To: <69894223.1144974540263.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HADOOP-135?page=all ] Owen O'Malley updated HADOOP-135: --------------------------------- Attachment: fix-lock-order.patch Reverse the order of locking for the two fields so that they are always acquired in the same order. > Potential deadlock in JobTracker. > --------------------------------- > > Key: HADOOP-135 > URL: http://issues.apache.org/jira/browse/HADOOP-135 > Project: Hadoop > Type: Bug > Components: mapred > Versions: 0.1.0 > Reporter: Konstantin Shvachko > Assignee: Owen O'Malley > Fix For: 0.4.0 > Attachments: fix-lock-order.patch > > org.apache.hadoop.mapred.JobTracker.RetireJobs.run() > locks resources in this order > synchronized (jobs) { > synchronized (jobInitQueue) { > synchronized (jobsByArrival) { > org.apache.hadoop.mapred.JobTracker.submitJob() > locks resources in a different order > synchronized (jobs) { > synchronized (jobsByArrival) { > synchronized (jobInitQueue) { > This potentially can lead to a deadlock. > Unless there is common lock on top of it in which case these > three locks are redundant. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira