Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 79698 invoked from network); 26 Jun 2006 21:26:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 26 Jun 2006 21:26:05 -0000 Received: (qmail 81520 invoked by uid 500); 26 Jun 2006 21:26:04 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 81374 invoked by uid 500); 26 Jun 2006 21:26:04 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 81365 invoked by uid 99); 26 Jun 2006 21:26:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jun 2006 14:26:04 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jun 2006 14:26:03 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A1C39410007 for ; Mon, 26 Jun 2006 21:24:30 +0000 (GMT) Message-ID: <17430417.1151357070659.JavaMail.jira@brutus> Date: Mon, 26 Jun 2006 21:24:30 +0000 (GMT+00:00) From: "Doug Cutting (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-321) DatanodeInfo refactoring In-Reply-To: <20976373.1151024969902.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HADOOP-321?page=comments#action_12417893 ] Doug Cutting commented on HADOOP-321: ------------------------------------- I like this. However we cannot simply remove DataNodeReport, since it's public, and may be referenced by user code. Rather, we should change it to a deprecated subclass of DatanodeInfo that defines no methods, and file a bug to remove it from the next release. Also, DatanodeInfo subclasses the non-public DatanodeID, so that class should probably be made public too. > DatanodeInfo refactoring > ------------------------ > > Key: HADOOP-321 > URL: http://issues.apache.org/jira/browse/HADOOP-321 > Project: Hadoop > Type: Improvement > Components: dfs > Reporter: Konstantin Shvachko > Attachments: DatanodeInfo_refactor.patch > > I'm trying to refactor some name node classes, which seem to be similar. > So DatanodeInfo is a public api now for purely external ( to name node) use. > The name node class that stores information about data nodes including the > set of its blocks is called DatanodeDescriptor. > The DatanodeReport is removed since it was a variation of DatanodeInfo. > Previously DatanodeInfo and DatanodeDescriptor were the same class, and > DatanodeReport was used for reporting node statistics only. > This is a preparation step for HADOOP-306. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira