hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-321) DatanodeInfo refactoring
Date Wed, 28 Jun 2006 19:57:30 GMT
     [ http://issues.apache.org/jira/browse/HADOOP-321?page=all ]

Konstantin Shvachko updated HADOOP-321:
---------------------------------------

    Attachment: DatanodeInfo_refactor3.patch

Sorry for submitting a bad path. I'm attaching the correct one.

It look like we have completely different views with Owen on how the inheritance should be
used in OOP.
In this particular case the derived class DatanodeDescriptor is intended to inherit and reuse
all members
of DatanodeInfo except for the Writable interface (2 methods). So the inheritance seems quite
logical to me.
Saves a lot of source code too.


> DatanodeInfo refactoring
> ------------------------
>
>          Key: HADOOP-321
>          URL: http://issues.apache.org/jira/browse/HADOOP-321
>      Project: Hadoop
>         Type: Improvement

>   Components: dfs
>     Reporter: Konstantin Shvachko
>     Assignee: Konstantin Shvachko
>      Fix For: 0.4.0
>  Attachments: DatanodeInfo_refactor.patch, DatanodeInfo_refactor3.patch
>
> I'm trying to refactor some name node classes, which seem to be similar.
> So DatanodeInfo is a public api now for purely external ( to name node) use.
> The name node class that stores information about data nodes including the
> set of its blocks is called DatanodeDescriptor.
> The DatanodeReport is removed since it was a variation of DatanodeInfo.
> Previously DatanodeInfo and DatanodeDescriptor were the same class, and
> DatanodeReport was used for reporting node statistics only.
> This is a preparation step for HADOOP-306.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message