hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-290) Fix Datanode transfer thread logging
Date Thu, 08 Jun 2006 15:43:30 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-290?page=comments#action_12415367 ] 

Owen O'Malley commented on HADOOP-290:
--------------------------------------

If you are doing anything other than a simple expression for logging, you should wrap the
whole block in a check to see if it will be logged.

if (LOG.isInfoEnabled()) {
   ...
   LOG.info(...);
}

That way if someone has logging turned off, they don't do the work of constructing the message.


> Fix Datanode transfer thread logging
> ------------------------------------
>
>          Key: HADOOP-290
>          URL: http://issues.apache.org/jira/browse/HADOOP-290
>      Project: Hadoop
>         Type: Bug

>   Components: dfs
>     Versions: 0.4.0
>  Environment: linux, java 1.5
>     Reporter: Dennis Kubes
>     Priority: Minor
>  Attachments: logging_patch
>
> Under the current datanode the logging of "Starting thread to transfer block" doesn't
print out the hosts that it is transferring to, it prints out a java array toString.  This
patch fixes this and prints out the hostnames and ports for all hosts we are tranferring to.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message