Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hadoop-dev@lucene.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <4474C9A4.2060201@dragonflymc.com>
Date: Wed, 24 May 2006 16:01:24 -0500
From: Dennis Kubes <nutch-dev@dragonflymc.com>
User-Agent: Thunderbird 1.5.0.2 (Windows/20060308)
MIME-Version: 1.0
To: hadoop-dev@lucene.apache.org
Subject: Re: unprotectedRenameTo and Non-Existent Parent Directory
References: <4474C69C.8010807@dragonflymc.com>
 <4474C8DC.2030301@yahoo-inc.com>
In-Reply-To: <4474C8DC.2030301@yahoo-inc.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

That is where I was headed as well.  I was thinking of adding something 
like fs.mkdirs(newLinkDb); in the install method.  I will submit a patch.

Dennis

Konstantin Shvachko wrote:
> This is a standard behavior of "mv". Don't think we should change it.
> I think it is better to call mkdirs before renaming.
>
> --Konst
>
> Dennis Kubes wrote:
>
>> Currently calls to unprotectedRenameTo in FSDirectory will not create 
>> parent directories of the rename path.  Should this behavior be 
>> changed to create the parent directories if they do not exist?
>>
>> This is effecting the LinkDB install method.  For example if I am 
>> creating a linkdb by the name of crawl/linkdb the install method 
>> calls a rename from working directory (something like linkdb-1234...) 
>> to crawl/linkdb/current.  But if the crawl/linkdb directory does not 
>> already exist then the rename fails.
>>
>> Dennis
>>
>>
>>
>