Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hadoop-dev@lucene.apache.org
Message-ID: <12717556.1148065890589.JavaMail.jira@brutus>
Date: Fri, 19 May 2006 19:11:30 +0000 (GMT+00:00)
From: "Doug Cutting (JIRA)" <jira@apache.org>
To: hadoop-dev@lucene.apache.org
Subject: [jira] Commented: (HADOOP-226) DFSShell problems. Incorrect block
 replication detection in fsck.
In-Reply-To: <24430703.1147903865906.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HADOOP-226?page=comments#action_12412576 ] 

Doug Cutting commented on HADOOP-226:
-------------------------------------

We should not try to parse all command line options in one place.  A generic class should parse out -D, -conf, -fs, etc. options, build a configuration, then the per-command class should parse the rest of the command line.  That's what HADOOP-59 is about.  Commons CLI could be used to implement the generic option parser and/or each command's option parser.

> DFSShell problems. Incorrect block replication detection in fsck.
> -----------------------------------------------------------------
>
>          Key: HADOOP-226
>          URL: http://issues.apache.org/jira/browse/HADOOP-226
>      Project: Hadoop
>         Type: Bug

>   Components: dfs
>  Environment: All
>     Reporter: Konstantin Shvachko

>
> 1. We need to adjust Dfsck to the new per-file replication feature.
> fsck checks block replication based on the configured global replication parameter.
> Which is now just the default. The actual file replication is returned in DFSFileInfo.
> So at least the reporting is screwed by that, although I didn't check what will happen with
> other options -move and -delete.
> 2. fsck throws NullPointerException if you type
> bin/hadoop fsck -files /doc
> instead of
> bin/hadoop fsck /doc -files
> 3. Unfortunately, there are several commands that throw different kinds of Exceptions
> rather than at least printing the usage info, when some of its arguments are missing or
> misplaced. ArrayIndexOutOfBoundsException is one them. Try
> bin/hadoop dfs -mv
> bin/hadoop dfs -cp
> bin/hadoop dfs -rm
> 4. In general the shell is growing and getting more sophisticated.
> Should we work out a general convention on how the parameters should be structured, named,
> short/long version of the keywords, help, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira