hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "alan wootton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-196) Fix buggy uselessness of Configuration( Configuration other) constructor
Date Thu, 04 May 2006 22:00:19 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-196?page=comments#action_12377895 ] 

alan wootton commented on HADOOP-196:
-------------------------------------

The constructor: 

	public Configuration(Configuration other)
	
sets the defaultResources, and the finalResources but does not use them 
because it then sets the properties to a clone of the other.properties.

If someone then calls addFinalResource (as does JobConf) then the
'other' properties are just lost. This becomes a problem if you attempt to use: 
	public JobConf(Class exampleClass)  

My fix (there are several possible ways to fix this) is to just remember
the other.properties and then overlay then whenever getProps() loads the resources.



> Fix buggy uselessness of Configuration( Configuration other) constructor
> ------------------------------------------------------------------------
>
>          Key: HADOOP-196
>          URL: http://issues.apache.org/jira/browse/HADOOP-196
>      Project: Hadoop
>         Type: Bug

>   Components: conf
>     Reporter: alan wootton
>  Attachments: ConfigConstructorFix.patch
>
> The constructor 
> public Configuration(Configuration other) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message