Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 32414 invoked from network); 18 Apr 2006 21:48:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Apr 2006 21:48:18 -0000 Received: (qmail 41594 invoked by uid 500); 18 Apr 2006 21:48:18 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 41576 invoked by uid 500); 18 Apr 2006 21:48:17 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 41566 invoked by uid 99); 18 Apr 2006 21:48:17 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 14:48:17 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 14:48:17 -0700 Received: from brutus (localhost.localdomain [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 148C37142C5 for ; Tue, 18 Apr 2006 21:47:18 +0000 (GMT) Message-ID: <5011285.1145396838080.JavaMail.jira@brutus> Date: Tue, 18 Apr 2006 21:47:18 +0000 (GMT+00:00) From: "Owen O'Malley (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Updated: (HADOOP-133) the TaskTracker.Child.ping thread calls exit In-Reply-To: <83642710.1144962600236.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HADOOP-133?page=all ] Owen O'Malley updated HADOOP-133: --------------------------------- Attachment: ping-stability.patch Here is a patch that allows retries for communication problems on the ping from the Task to the TaskTracker. It changes the interface of ping from returning nothing to returning a boolean. A false return value means the child should immediately go away. Exceptions are treated as temporary problems and given 3 chances. This patch also changes the exit code to be either 65 (asked to kill self) or 66 (ping exception). > the TaskTracker.Child.ping thread calls exit > -------------------------------------------- > > Key: HADOOP-133 > URL: http://issues.apache.org/jira/browse/HADOOP-133 > Project: Hadoop > Type: Bug > Components: mapred > Versions: 0.1.1 > Reporter: Owen O'Malley > Assignee: Owen O'Malley > Attachments: ping-stability.patch > > The TaskTracker.Child.startPinging thread calls exit if the TaskTracker doesn't respond. Calling exit in a mutli-threaded program is really problematic. In particular, it prevents cleanup/finally clauses from running. We need to move to a model where it uses Thread.interrupt(), which means we need to check the interrupt flag in place in the map loop and reduce loop and stop masking the InterruptExceptions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira