Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 74996 invoked from network); 4 Apr 2006 17:23:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Apr 2006 17:23:49 -0000 Received: (qmail 12068 invoked by uid 500); 4 Apr 2006 17:23:48 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 12047 invoked by uid 500); 4 Apr 2006 17:23:48 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 12038 invoked by uid 99); 4 Apr 2006 17:23:48 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Apr 2006 10:23:48 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [69.44.16.11] (HELO getopt.org) (69.44.16.11) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Apr 2006 10:23:47 -0700 Received: from [192.168.0.253] (75-mo3-2.acn.waw.pl [62.121.105.75]) (authenticated) by getopt.org (8.11.6/8.11.6) with ESMTP id k34HNcX15345 for ; Tue, 4 Apr 2006 12:23:38 -0500 Message-ID: <4432AB80.50609@getopt.org> Date: Tue, 04 Apr 2006 19:23:12 +0200 From: Andrzej Bialecki User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: hadoop-dev@lucene.apache.org Subject: Re: svn commit: r390260 - /lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/MapReduceBase.java References: <20060330222235.98730.qmail@minotaur.apache.org> <44324F14.1020403@getopt.org> <1aac7add45d58f024d1b350c545b6c38@yahoo-inc.com> In-Reply-To: <1aac7add45d58f024d1b350c545b6c38@yahoo-inc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Owen O'Malley wrote: > > On Apr 4, 2006, at 3:48 AM, Andrzej Bialecki wrote: >> >> Shouldn't this method throw an IOException, as it is declared in >> Closeable? > > Yes, it should. Thanks for the catch Andrzej. What is interesting is that javac didn't catch it either... strange. I need to read a good book on Java basics, it seems. ;) It makes sense also to add the throws clause to configure, I think, as Darek suggested in another post. -- Best regards, Andrzej Bialecki <>< ___. ___ ___ ___ _ _ __________________________________ [__ || __|__/|__||\/| Information Retrieval, Semantic Web ___|||__|| \| || | Embedded Unix, System Integration http://www.sigram.com Contact: info at sigram dot com