hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry Ogrodnek" <Lawre...@theladders.com>
Subject RE: code checker
Date Wed, 05 Apr 2006 20:28:13 GMT
CheckStyle [http://checkstyle.sourceforge.net/] is also pretty neat.
While it's more a coding style checker than a static code checker, it
does report on unused imports, unnecessary modifiers/casting, cyclomatic
complexity, etc.

It might be worth setting up in addition to either PMD or findbugs.

-----Original Message-----
From: Owen O'Malley [mailto:owen@yahoo-inc.com] 
Sent: Wednesday, April 05, 2006 4:21 PM
To: hadoop-dev@lucene.apache.org
Subject: Re: code checker

On Apr 5, 2006, at 12:07 PM, Doug Cutting wrote:

> The issue of unused variables and imports has come up for Hadoop. 
> Different folks use different development environments, not all of 
> which warn about the same things.  Perhaps if we integrated a code 
> checker into Hadoop's build process then we could more easily 
> guarantee that commits are not made that contain such things.
> The PMD project includes an Ant task that implements code checking:

Code checkers are good. The last time I used them, findBugs 
(http://findbugs.sourceforge.net/) was better than PMD in terms of both 
finding "real" things and a lower false positive rate.

-- Owen

View raw message