hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-62) can't get environment variables from HADOOP_CONF_DIR
Date Thu, 02 Mar 2006 00:56:01 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-62?page=comments#action_12368409 ] 

Owen O'Malley commented on HADOOP-62:
-------------------------------------

> Shouldn't we also make similar changes in the other scripts that source hadoop-env.sh?

of course. I just missed the fact that they had similar mistakes in them.

> Also, wouldn't it be cleaner to assign & default HADOOP_CONF_DIR in a separate line,
rather than as 
> a side-effect the first time its used?

I was just trying to copy your style, since it was your script.

> Finally, why kill the comment about CLASSPATH?

After the conditional assignment was removed, it seemed like a "add one to x" type comment.
A better comment would be:

# The configuration directory needs to be first in the classpath so that the config files
are found by the 
# classloader.


> can't get environment variables from HADOOP_CONF_DIR
> ----------------------------------------------------
>
>          Key: HADOOP-62
>          URL: http://issues.apache.org/jira/browse/HADOOP-62
>      Project: Hadoop
>         Type: Bug
>   Components: conf
>     Versions: 0.1
>     Reporter: Owen O'Malley
>     Assignee: Owen O'Malley
>     Priority: Minor
>      Fix For: 0.1
>  Attachments: conf_dir.patch
>
> The bin/hadoop script doesn't use the HADOOP_CONF_DIR variable to find hadoop-env.sh.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message