hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-40) bufferSize argument is ignored in FileSystem.create(File, boolean, int)
Date Fri, 24 Feb 2006 23:25:38 GMT
    [ http://issues.apache.org/jira/browse/HADOOP-40?page=comments#action_12367738 ] 

Konstantin Shvachko commented on HADOOP-40:
-------------------------------------------

Yes. This is the right way of doing it.
It particularly makes sense, since the main file and the checksum file
do not necessarily need to share the same buffer size.
With the file buffer large the checksum buffer doesn't need to be large at all.

> bufferSize argument is ignored in FileSystem.create(File, boolean, int)
> -----------------------------------------------------------------------
>
>          Key: HADOOP-40
>          URL: http://issues.apache.org/jira/browse/HADOOP-40
>      Project: Hadoop
>         Type: Bug
>   Components: fs
>     Reporter: Konstantin Shvachko
>     Priority: Minor
>      Fix For: 0.1
>  Attachments: BufferSize.patch, bufferSize.patch
>
> org.apache.hadoop.fs.FileSystem.create(File f, boolean overwrite, int bufferSize)
> ignores the input parameter bufferSize.
> It passes further down the internal configuration, which includes the buffer size, but
not the parameter value.
> This works fine within the file system, since everything that calls create extracts buffer
size from the same config. 
> MapReduce although is probably affected by that, see 
> org.apache.hadoop.io.SequenceFile.Sorter.MergeQueue.MergeQueue(int size, String outName,
boolean done)
> The attached patch would fix it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message