From common-commits-return-86227-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jul 31 11:25:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1EF3318067B for ; Tue, 31 Jul 2018 11:25:49 +0200 (CEST) Received: (qmail 75461 invoked by uid 500); 31 Jul 2018 09:25:44 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 75041 invoked by uid 99); 31 Jul 2018 09:25:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2018 09:25:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A8A7AE116F; Tue, 31 Jul 2018 09:25:43 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ehiggs@apache.org To: common-commits@hadoop.apache.org Date: Tue, 31 Jul 2018 09:26:02 -0000 Message-Id: <2a174f77faf34c55b067e90736ba3a8b@git.apache.org> In-Reply-To: <4e533beaec11404caf0635c07bf3761a@git.apache.org> References: <4e533beaec11404caf0635c07bf3761a@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [20/50] hadoop git commit: HADOOP-15611. Log more details for FairCallQueue. Contributed by Ryan Wu. HADOOP-15611. Log more details for FairCallQueue. Contributed by Ryan Wu. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/9089790c Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/9089790c Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/9089790c Branch: refs/heads/HDFS-12090 Commit: 9089790cabb4771198be0fe64c1317a3ff1c80f1 Parents: f93ecf5 Author: Yiqun Lin Authored: Thu Jul 26 18:08:28 2018 +0800 Committer: Yiqun Lin Committed: Thu Jul 26 18:08:28 2018 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java | 8 ++++++++ .../org/apache/hadoop/ipc/WeightedRoundRobinMultiplexer.java | 3 +++ 2 files changed, 11 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/9089790c/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java index f12ecb6..8bb0ce4 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java @@ -391,6 +391,7 @@ public class DecayRpcScheduler implements RpcScheduler, * counts current. */ private void decayCurrentCounts() { + LOG.debug("Start to decay current counts."); try { long totalDecayedCount = 0; long totalRawCount = 0; @@ -410,7 +411,12 @@ public class DecayRpcScheduler implements RpcScheduler, totalDecayedCount += nextValue; decayedCount.set(nextValue); + LOG.debug("Decaying counts for the user: {}, " + + "its decayedCount: {}, rawCount: {}", entry.getKey(), + nextValue, rawCount.get()); if (nextValue == 0) { + LOG.debug("The decayed count for the user {} is zero " + + "and being cleaned.", entry.getKey()); // We will clean up unused keys here. An interesting optimization // might be to have an upper bound on keyspace in callCounts and only // clean once we pass it. @@ -422,6 +428,8 @@ public class DecayRpcScheduler implements RpcScheduler, totalDecayedCallCount.set(totalDecayedCount); totalRawCallCount.set(totalRawCount); + LOG.debug("After decaying the stored counts, totalDecayedCount: {}, " + + "totalRawCallCount: {}.", totalDecayedCount, totalRawCount); // Now refresh the cache of scheduling decisions recomputeScheduleCache(); http://git-wip-us.apache.org/repos/asf/hadoop/blob/9089790c/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WeightedRoundRobinMultiplexer.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WeightedRoundRobinMultiplexer.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WeightedRoundRobinMultiplexer.java index d308725..096cc1a 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WeightedRoundRobinMultiplexer.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WeightedRoundRobinMultiplexer.java @@ -109,6 +109,9 @@ public class WeightedRoundRobinMultiplexer implements RpcMultiplexer { // Finally, reset requestsLeft. This will enable moveToNextQueue to be // called again, for the new currentQueueIndex this.requestsLeft.set(this.queueWeights[nextIdx]); + LOG.debug("Moving to next queue from queue index {} to index {}, " + + "number of requests left for current queue: {}.", + thisIdx, nextIdx, requestsLeft); } /** --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-commits-help@hadoop.apache.org