Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 319D5200C63 for ; Thu, 11 May 2017 18:58:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3043C160BCD; Thu, 11 May 2017 16:58:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 77BD2160BCC for ; Thu, 11 May 2017 18:58:51 +0200 (CEST) Received: (qmail 15131 invoked by uid 500); 11 May 2017 16:58:43 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 13756 invoked by uid 99); 11 May 2017 16:58:43 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 16:58:43 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0AA5FE95BF; Thu, 11 May 2017 16:58:43 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: inigoiri@apache.org To: common-commits@hadoop.apache.org Date: Thu, 11 May 2017 16:59:01 -0000 Message-Id: In-Reply-To: <9a45bd10f8a94e45ad39713e44db6c8b@git.apache.org> References: <9a45bd10f8a94e45ad39713e44db6c8b@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [20/50] [abbrv] hadoop git commit: HADOOP-14384. Reduce the visibility of FileSystem.newFSDataOutputStreamBuilder before the API becomes stable. (lei) archived-at: Thu, 11 May 2017 16:58:52 -0000 HADOOP-14384. Reduce the visibility of FileSystem.newFSDataOutputStreamBuilder before the API becomes stable. (lei) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/149b903b Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/149b903b Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/149b903b Branch: refs/heads/HDFS-10467 Commit: 149b903be30e2b973691c30ee02f0d5b53ca0abc Parents: 543aac9 Author: Lei Xu Authored: Tue May 9 10:27:17 2017 -0700 Committer: Lei Xu Committed: Tue May 9 10:27:17 2017 -0700 ---------------------------------------------------------------------- .../java/org/apache/hadoop/fs/FSDataOutputStreamBuilder.java | 8 ++++++-- .../src/main/java/org/apache/hadoop/fs/FileSystem.java | 6 +++++- .../src/main/java/org/apache/hadoop/fs/FilterFileSystem.java | 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/149b903b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStreamBuilder.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStreamBuilder.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStreamBuilder.java index 2e885f3..55836cc 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStreamBuilder.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStreamBuilder.java @@ -18,6 +18,8 @@ package org.apache.hadoop.fs; import com.google.common.base.Preconditions; +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.fs.Options.ChecksumOpt; import org.apache.hadoop.fs.permission.FsPermission; import org.apache.hadoop.util.Progressable; @@ -29,7 +31,9 @@ import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.IO_FILE_BUFFER_ import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.IO_FILE_BUFFER_SIZE_KEY; /** Base of specific file system FSDataOutputStreamBuilder. */ -public class FSDataOutputStreamBuilder{ +@InterfaceAudience.Private +@InterfaceStability.Unstable +public class FSDataOutputStreamBuilder { private Path path = null; private FsPermission permission = null; private Integer bufferSize; @@ -41,7 +45,7 @@ public class FSDataOutputStreamBuilder{ private final FileSystem fs; - public FSDataOutputStreamBuilder(FileSystem fileSystem, Path p) { + protected FSDataOutputStreamBuilder(FileSystem fileSystem, Path p) { fs = fileSystem; path = p; } http://git-wip-us.apache.org/repos/asf/hadoop/blob/149b903b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java index 29da214..1907475 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java @@ -4144,8 +4144,12 @@ public abstract class FileSystem extends Configured implements Closeable { * Create a new FSDataOutputStreamBuilder for the file with path. * @param path file path * @return a FSDataOutputStreamBuilder object to build the file + * + * HADOOP-14384. Temporarily reduce the visibility of method before the + * builder interface becomes stable. */ - public FSDataOutputStreamBuilder newFSDataOutputStreamBuilder(Path path) { + @InterfaceAudience.Private + protected FSDataOutputStreamBuilder newFSDataOutputStreamBuilder(Path path) { return new FSDataOutputStreamBuilder(this, path); } } http://git-wip-us.apache.org/repos/asf/hadoop/blob/149b903b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java index ef09458..3466922 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java @@ -667,7 +667,7 @@ public class FilterFileSystem extends FileSystem { } @Override - public FSDataOutputStreamBuilder newFSDataOutputStreamBuilder(Path path) { + protected FSDataOutputStreamBuilder newFSDataOutputStreamBuilder(Path path) { return fs.newFSDataOutputStreamBuilder(path); } } --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-commits-help@hadoop.apache.org