Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BFFC0200C4B for ; Mon, 20 Mar 2017 19:48:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BED5A160B71; Mon, 20 Mar 2017 18:48:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 163AC160B92 for ; Mon, 20 Mar 2017 19:48:41 +0100 (CET) Received: (qmail 98447 invoked by uid 500); 20 Mar 2017 18:45:14 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 98279 invoked by uid 99); 20 Mar 2017 18:45:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Mar 2017 18:45:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 50C43E00A3; Mon, 20 Mar 2017 18:45:13 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: inigoiri@apache.org To: common-commits@hadoop.apache.org Date: Mon, 20 Mar 2017 18:45:18 -0000 Message-Id: In-Reply-To: <6f9faa64902e4d94a35a8362a0b590c3@git.apache.org> References: <6f9faa64902e4d94a35a8362a0b590c3@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [6/9] hadoop git commit: HDFS-11547. Add logs for slow BlockReceiver while writing data to disk. Contributed by Xiaobing Zhou. archived-at: Mon, 20 Mar 2017 18:48:42 -0000 HDFS-11547. Add logs for slow BlockReceiver while writing data to disk. Contributed by Xiaobing Zhou. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/ffa160dd Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/ffa160dd Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/ffa160dd Branch: refs/heads/HDFS-10467 Commit: ffa160ddb824cbcb8ab6b10ee1414507686e3c63 Parents: e1a9980 Author: Arpit Agarwal Authored: Fri Mar 17 19:02:24 2017 -0700 Committer: Arpit Agarwal Committed: Fri Mar 17 19:02:24 2017 -0700 ---------------------------------------------------------------------- .../org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/ffa160dd/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java index 5852403a..bb6bd55 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java @@ -711,6 +711,10 @@ class BlockReceiver implements Closeable { streams.writeDataToDisk(dataBuf.array(), startByteToDisk, numBytesToDisk); long duration = Time.monotonicNow() - begin; + if (duration > datanodeSlowLogThresholdMs) { + LOG.warn("Slow BlockReceiver write data to disk cost:" + duration + + "ms (threshold=" + datanodeSlowLogThresholdMs + "ms)"); + } if (duration > maxWriteToDiskMs) { maxWriteToDiskMs = duration; --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-commits-help@hadoop.apache.org