hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From inigo...@apache.org
Subject [05/13] hadoop git commit: YARN-6329. Remove unnecessary TODO comment from AppLogAggregatorImpl.java. Contributed by victor bertschinger.
Date Thu, 30 Mar 2017 02:35:46 GMT
YARN-6329. Remove unnecessary TODO comment from AppLogAggregatorImpl.java. Contributed by victor
bertschinger.


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/14434c75
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/14434c75
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/14434c75

Branch: refs/heads/HDFS-10467
Commit: 14434c758246990606f2fcb7104dceb5e1947187
Parents: ffb9786
Author: Akira Ajisaka <aajisaka@apache.org>
Authored: Wed Mar 29 10:35:30 2017 +0900
Committer: Inigo <inigoiri@apache.org>
Committed: Wed Mar 29 19:32:11 2017 -0700

----------------------------------------------------------------------
 .../containermanager/logaggregation/AppLogAggregatorImpl.java      | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/14434c75/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
----------------------------------------------------------------------
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
index 065854e..d70acc9 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
@@ -573,8 +573,6 @@ public class AppLogAggregatorImpl implements AppLogAggregator {
       (remoteNodeLogFileForApp.getName() + LogAggregationUtils.TMP_FILE_SUFFIX));
   }
 
-  // TODO: The condition: containerId.getId() == 1 to determine an AM container
-  // is not always true.
   private boolean shouldUploadLogs(ContainerLogContext logContext) {
     return logAggPolicy.shouldDoLogAggregation(logContext);
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org


Mime
View raw message