Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 753A7200BAA for ; Thu, 27 Oct 2016 08:50:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 73D8E160AF6; Thu, 27 Oct 2016 06:50:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BE8E4160AE4 for ; Thu, 27 Oct 2016 08:50:47 +0200 (CEST) Received: (qmail 38119 invoked by uid 500); 27 Oct 2016 06:50:46 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 38110 invoked by uid 99); 27 Oct 2016 06:50:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 06:50:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8761EDFC70; Thu, 27 Oct 2016 06:50:46 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: vinayakumarb@apache.org To: common-commits@hadoop.apache.org Message-Id: <7e98d37b1b5444a19b42650827512081@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hadoop git commit: HDFS-9929. Duplicate keys in NAMENODE_SPECIFIC_KEYS (Contributed by Akira Ajisaka) Date: Thu, 27 Oct 2016 06:50:46 +0000 (UTC) archived-at: Thu, 27 Oct 2016 06:50:48 -0000 Repository: hadoop Updated Branches: refs/heads/trunk 0bdd263d8 -> a895c6625 HDFS-9929. Duplicate keys in NAMENODE_SPECIFIC_KEYS (Contributed by Akira Ajisaka) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/a895c662 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/a895c662 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/a895c662 Branch: refs/heads/trunk Commit: a895c66255533b73e2a04c44693b03dc7011340b Parents: 0bdd263 Author: Vinayakumar B Authored: Thu Oct 27 12:17:05 2016 +0530 Committer: Vinayakumar B Committed: Thu Oct 27 12:20:15 2016 +0530 ---------------------------------------------------------------------- .../hadoop/hdfs/server/namenode/NameNode.java | 1 - .../namenode/TestNameNodeConfiguration.java | 40 ++++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/a895c662/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java index b380d19..d825177 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java @@ -268,7 +268,6 @@ public class NameNode extends ReconfigurableBase implements DFS_NAMENODE_KERBEROS_INTERNAL_SPNEGO_PRINCIPAL_KEY, DFS_HA_FENCE_METHODS_KEY, DFS_HA_ZKFC_PORT_KEY, - DFS_HA_FENCE_METHODS_KEY }; /** http://git-wip-us.apache.org/repos/asf/hadoop/blob/a895c662/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeConfiguration.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeConfiguration.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeConfiguration.java new file mode 100644 index 0000000..c42c3d9 --- /dev/null +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeConfiguration.java @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdfs.server.namenode; + +import org.junit.Test; + +import java.util.HashSet; +import java.util.Set; + +import static org.junit.Assert.assertTrue; + +public class TestNameNodeConfiguration { + + /** + * Detect duplicate keys in {@link NameNode#NAMENODE_SPECIFIC_KEYS}. + */ + @Test + public void testNameNodeSpecificKeys() { + Set keySet = new HashSet<>(); + for (String key : NameNode.NAMENODE_SPECIFIC_KEYS) { + assertTrue("Duplicate key: " + key + + " in NameNode.NAMENODE_SPECIFIC_KEYS.", keySet.add(key)); + } + } +} --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-commits-help@hadoop.apache.org