Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7381A200B88 for ; Wed, 17 Aug 2016 19:58:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 722DE160ABE; Wed, 17 Aug 2016 17:58:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CDC5B160A8C for ; Wed, 17 Aug 2016 19:58:35 +0200 (CEST) Received: (qmail 32103 invoked by uid 500); 17 Aug 2016 17:58:32 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 31703 invoked by uid 99); 17 Aug 2016 17:58:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2016 17:58:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E6BABEEE3D; Wed, 17 Aug 2016 17:58:31 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: wangda@apache.org To: common-commits@hadoop.apache.org Date: Wed, 17 Aug 2016 17:58:37 -0000 Message-Id: In-Reply-To: <8e15cbc2ee6943ccb04a0291d8c2e833@git.apache.org> References: <8e15cbc2ee6943ccb04a0291d8c2e833@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [07/50] [abbrv] hadoop git commit: HDFS-10567. Improve plan command help message. Contributed by Xiaobing Zhou. archived-at: Wed, 17 Aug 2016 17:58:36 -0000 HDFS-10567. Improve plan command help message. Contributed by Xiaobing Zhou. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/02abd131 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/02abd131 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/02abd131 Branch: refs/heads/YARN-3368 Commit: 02abd131b857a89d9fc21507296603120bb50810 Parents: 9daa997 Author: Anu Engineer Authored: Mon Aug 15 19:54:06 2016 -0700 Committer: Anu Engineer Committed: Mon Aug 15 19:58:57 2016 -0700 ---------------------------------------------------------------------- .../apache/hadoop/hdfs/tools/DiskBalancer.java | 29 ++++++++++++-------- 1 file changed, 18 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/02abd131/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DiskBalancer.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DiskBalancer.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DiskBalancer.java index 70912d0..1ed2fdc 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DiskBalancer.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DiskBalancer.java @@ -266,33 +266,40 @@ public class DiskBalancer extends Configured implements Tool { private void addPlanCommands(Options opt) { Option plan = OptionBuilder.withLongOpt(PLAN) - .withDescription("creates a plan for datanode.") + .withDescription("Hostname, IP address or UUID of datanode " + + "for which a plan is created.") .hasArg() .create(); getPlanOptions().addOption(plan); opt.addOption(plan); - Option outFile = OptionBuilder.withLongOpt(OUTFILE) - .hasArg() - .withDescription("File to write output to, if not specified " + - "defaults will be used.") + Option outFile = OptionBuilder.withLongOpt(OUTFILE).hasArg() + .withDescription( + "Local path of file to write output to, if not specified " + + "defaults will be used.") .create(); getPlanOptions().addOption(outFile); opt.addOption(outFile); - Option bandwidth = OptionBuilder.withLongOpt(BANDWIDTH) - .hasArg() - .withDescription("Maximum disk bandwidth to be consumed by " + - "diskBalancer. e.g. 10") + Option bandwidth = OptionBuilder.withLongOpt(BANDWIDTH).hasArg() + .withDescription( + "Maximum disk bandwidth (MB/s) in integer to be consumed by " + + "diskBalancer. e.g. 10 MB/s.") .create(); getPlanOptions().addOption(bandwidth); opt.addOption(bandwidth); Option threshold = OptionBuilder.withLongOpt(THRESHOLD) .hasArg() - .withDescription("Percentage skew that we" + - "tolerate before diskbalancer starts working e.g. 10") + .withDescription("Percentage of data skew that is tolerated before" + + " disk balancer starts working. For example, if" + + " total data on a 2 disk node is 100 GB then disk" + + " balancer calculates the expected value on each disk," + + " which is 50 GB. If the tolerance is 10% then data" + + " on a single disk needs to be more than 60 GB" + + " (50 GB + 10% tolerance value) for Disk balancer to" + + " balance the disks.") .create(); getPlanOptions().addOption(threshold); opt.addOption(threshold); --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-commits-help@hadoop.apache.org