Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26C7F200AF7 for ; Tue, 14 Jun 2016 12:31:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 255B0160A47; Tue, 14 Jun 2016 10:31:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 69BFB1602C5 for ; Tue, 14 Jun 2016 12:31:58 +0200 (CEST) Received: (qmail 34673 invoked by uid 500); 14 Jun 2016 10:31:57 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 34664 invoked by uid 99); 14 Jun 2016 10:31:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jun 2016 10:31:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 18C2AE0200; Tue, 14 Jun 2016 10:31:57 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: vinayakumarb@apache.org To: common-commits@hadoop.apache.org Message-Id: <769b09a3e2c94f439164d13071a58789@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hadoop git commit: HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe. (Contributed by hongbin ma) Date: Tue, 14 Jun 2016 10:31:57 +0000 (UTC) archived-at: Tue, 14 Jun 2016 10:31:59 -0000 Repository: hadoop Updated Branches: refs/heads/trunk 20b13d109 -> 8e8cb4c6c HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe. (Contributed by hongbin ma) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/8e8cb4c6 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/8e8cb4c6 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/8e8cb4c6 Branch: refs/heads/trunk Commit: 8e8cb4c6ca7e803674b160946ac92274bac0f96d Parents: 20b13d1 Author: Vinayakumar B Authored: Tue Jun 14 15:58:04 2016 +0530 Committer: Vinayakumar B Committed: Tue Jun 14 16:01:26 2016 +0530 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/util/GenericOptionsParser.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/8e8cb4c6/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java index 17ce730..8a06b1f 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java @@ -208,7 +208,7 @@ public class GenericOptionsParser { * Specify properties of each generic option */ @SuppressWarnings("static-access") - private static Options buildGeneralOptions(Options opts) { + private static synchronized Options buildGeneralOptions(Options opts) { Option fs = OptionBuilder.withArgName("local|namenode:port") .hasArg() .withDescription("specify a namenode") --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-commits-help@hadoop.apache.org