hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aengin...@apache.org
Subject [01/18] hadoop git commit: HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe. (Contributed by hongbin ma)
Date Sat, 18 Jun 2016 16:54:05 GMT
Repository: hadoop
Updated Branches:
  refs/heads/HDFS-1312 982bee0a1 -> 13599a8a4


HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is
not thread-safe. (Contributed by hongbin ma)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/a2192253
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/a2192253
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/a2192253

Branch: refs/heads/HDFS-1312
Commit: a2192253181255e2023171ef14d288866d9bb5d7
Parents: 4ab2480
Author: Vinayakumar B <vinayakumarb@apache.org>
Authored: Tue Jun 14 15:58:04 2016 +0530
Committer: Anu Engineer <aengineer@apache.org>
Committed: Sat Jun 18 00:05:01 2016 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/hadoop/util/GenericOptionsParser.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/a2192253/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
index 17ce730..8a06b1f 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
@@ -208,7 +208,7 @@ public class GenericOptionsParser {
    * Specify properties of each generic option
    */
   @SuppressWarnings("static-access")
-  private static Options buildGeneralOptions(Options opts) {
+  private static synchronized Options buildGeneralOptions(Options opts) {
     Option fs = OptionBuilder.withArgName("local|namenode:port")
     .hasArg()
     .withDescription("specify a namenode")


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org


Mime
View raw message