hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject [1/2] hadoop git commit: HADOOP-12514. Make static fields in GenericTestUtils for assertExceptionContains() package-private and final. (Mingliang Liu via stevel)
Date Wed, 28 Oct 2015 10:36:52 GMT
Repository: hadoop
Updated Branches:
  refs/heads/branch-2 d29bff86c -> fe079c8b2
  refs/heads/trunk ff2b2bea9 -> a04b16970


HADOOP-12514. Make static fields in GenericTestUtils for  assertExceptionContains() package-private
and final. (Mingliang Liu via stevel)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/fe079c8b
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/fe079c8b
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/fe079c8b

Branch: refs/heads/branch-2
Commit: fe079c8b204b6fd8f17f9459a27781303f8acb3a
Parents: d29bff8
Author: Steve Loughran <stevel@apache.org>
Authored: Wed Oct 28 10:36:26 2015 +0000
Committer: Steve Loughran <stevel@apache.org>
Committed: Wed Oct 28 10:36:26 2015 +0000

----------------------------------------------------------------------
 hadoop-common-project/hadoop-common/CHANGES.txt               | 4 ++++
 .../test/java/org/apache/hadoop/test/GenericTestUtils.java    | 7 +++----
 2 files changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/fe079c8b/hadoop-common-project/hadoop-common/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 9561068..e77d7c7 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -319,6 +319,10 @@ Release 2.8.0 - UNRELEASED
     HADOOP-12472. Make GenericTestUtils.assertExceptionContains robust.
     (Steve Loughran via jing9)
 
+    HADOOP-12514. Make static fields in GenericTestUtils for
+    assertExceptionContains() package-private and final.
+    (Mingliang Liu via stevel)
+
     HADOOP-12520. Use XInclude in hadoop-azure test configuration to isolate
     Azure Storage account keys for service integration tests. (cnauroth)
 

http://git-wip-us.apache.org/repos/asf/hadoop/blob/fe079c8b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
index 3f0b89d..02e9faa 100644
--- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
@@ -143,11 +143,10 @@ public abstract class GenericTestUtils {
         Joiner.on(",").join(found));
   }
 
-  protected static String E_NULL_THROWABLE = "Null Throwable";
-  protected static String E_NULL_THROWABLE_STRING =
+  static final String E_NULL_THROWABLE = "Null Throwable";
+  static final String E_NULL_THROWABLE_STRING =
       "Null Throwable.toString() value";
-  protected static String E_UNEXPECTED_EXCEPTION =
-      "but got unexpected exception";
+  static final String E_UNEXPECTED_EXCEPTION = "but got unexpected exception";
 
   /**
    * Assert that an exception's <code>toString()</code> value


Mime
View raw message