Return-Path: X-Original-To: apmail-hadoop-common-commits-archive@www.apache.org Delivered-To: apmail-hadoop-common-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65A0018133 for ; Mon, 13 Jul 2015 17:53:18 +0000 (UTC) Received: (qmail 11444 invoked by uid 500); 13 Jul 2015 17:53:18 -0000 Delivered-To: apmail-hadoop-common-commits-archive@hadoop.apache.org Received: (qmail 11376 invoked by uid 500); 13 Jul 2015 17:53:18 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 11365 invoked by uid 99); 13 Jul 2015 17:53:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 17:53:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 003E0E03C2; Mon, 13 Jul 2015 17:53:17 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: aw@apache.org To: common-commits@hadoop.apache.org Message-Id: <587b9424877c4c8eb27fe44630b5993d@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hadoop git commit: HADOOP-12196. shellcheck plugin is picking up target executables (Kengo Seki via aw) Date: Mon, 13 Jul 2015 17:53:17 +0000 (UTC) Repository: hadoop Updated Branches: refs/heads/HADOOP-12111 4bc87cd2d -> 5e1985501 HADOOP-12196. shellcheck plugin is picking up target executables (Kengo Seki via aw) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/5e198550 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/5e198550 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/5e198550 Branch: refs/heads/HADOOP-12111 Commit: 5e19855013c1254b5db66a9b5009fa0458cd8d8e Parents: 4bc87cd Author: Allen Wittenauer Authored: Mon Jul 13 10:53:09 2015 -0700 Committer: Allen Wittenauer Committed: Mon Jul 13 10:53:09 2015 -0700 ---------------------------------------------------------------------- dev-support/test-patch.d/shellcheck.sh | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/5e198550/dev-support/test-patch.d/shellcheck.sh ---------------------------------------------------------------------- diff --git a/dev-support/test-patch.d/shellcheck.sh b/dev-support/test-patch.d/shellcheck.sh index 1c06a5d..0ccd1c0 100755 --- a/dev-support/test-patch.d/shellcheck.sh +++ b/dev-support/test-patch.d/shellcheck.sh @@ -47,7 +47,15 @@ function shellcheck_private_findbash while read line; do value=$(find "${line}" ! -name '*.cmd' -type f \ | ${GREP} -E -v '(.orig$|.rej$)') - list="${list} ${value}" + + for i in ${value}; do + if [[ ! ${i} =~ \.sh(\.|$) + && ! $(head -n 1 "${i}") =~ ^#! ]]; then + yetus_debug "Shellcheck skipped: ${i}" + continue + fi + list="${list} ${i}" + done done < <(find . -type d -name bin -o -type d -name sbin -o -type d -name libexec -o -type d -name shellprofile.d) # shellcheck disable=SC2086 echo ${list} ${SHELLCHECK_SPECIFICFILES} | tr ' ' '\n' | sort -u @@ -137,6 +145,9 @@ function shellcheck_calcdiffs function shellcheck_postapply { local i + local numPrepatch + local numPostpatch + local diffPostpatch verify_needed_test shellcheck if [[ $? == 0 ]]; then