Return-Path: X-Original-To: apmail-hadoop-common-commits-archive@www.apache.org Delivered-To: apmail-hadoop-common-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00D7318974 for ; Tue, 21 Jul 2015 18:25:06 +0000 (UTC) Received: (qmail 38381 invoked by uid 500); 21 Jul 2015 18:25:04 -0000 Delivered-To: apmail-hadoop-common-commits-archive@hadoop.apache.org Received: (qmail 38046 invoked by uid 500); 21 Jul 2015 18:25:04 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 37877 invoked by uid 99); 21 Jul 2015 18:25:04 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jul 2015 18:25:04 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 74C64E1806; Tue, 21 Jul 2015 18:25:04 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: aengineer@apache.org To: common-commits@hadoop.apache.org Date: Tue, 21 Jul 2015 18:25:08 -0000 Message-Id: <298de6e2240f48f38a391c6fe76b83c1@git.apache.org> In-Reply-To: <522a5956e161468e8c6334f90bcb1d6a@git.apache.org> References: <522a5956e161468e8c6334f90bcb1d6a@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [05/19] hadoop git commit: HADOOP-12051. ProtobufRpcEngine.invoke() should use Exception.toString() over getMessage() in logging/span events. (Varun Saxena via stevel) HADOOP-12051. ProtobufRpcEngine.invoke() should use Exception.toString() over getMessage() in logging/span events. (Varun Saxena via stevel) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/a9431425 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/a9431425 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/a9431425 Branch: refs/heads/HDFS-7240 Commit: a9431425d1aff657fc1ea501c706235f2ebc518f Parents: 05fa336 Author: Steve Loughran Authored: Mon Jul 20 13:13:09 2015 +0100 Committer: Steve Loughran Committed: Mon Jul 20 13:13:23 2015 +0100 ---------------------------------------------------------------------- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/a9431425/hadoop-common-project/hadoop-common/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index bfa9aac..1b643a9 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -978,6 +978,9 @@ Release 2.8.0 - UNRELEASED HADOOP-12088. KMSClientProvider uses equalsIgnoreCase("application/json"). (Brahma Reddy Battula via stevel) + HADOOP-12051. ProtobufRpcEngine.invoke() should use Exception.toString() + over getMessage() in logging/span events. (Varun Saxena via stevel) + Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES http://git-wip-us.apache.org/repos/asf/hadoop/blob/a9431425/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java index e75de15..cc75f5c 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java @@ -238,7 +238,7 @@ public class ProtobufRpcEngine implements RpcEngine { } if (Trace.isTracing()) { traceScope.getSpan().addTimelineAnnotation( - "Call got exception: " + e.getMessage()); + "Call got exception: " + e.toString()); } throw new ServiceException(e); } finally {