Return-Path: X-Original-To: apmail-hadoop-common-commits-archive@www.apache.org Delivered-To: apmail-hadoop-common-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EDE0318D01 for ; Thu, 14 May 2015 08:48:41 +0000 (UTC) Received: (qmail 49823 invoked by uid 500); 14 May 2015 08:48:41 -0000 Delivered-To: apmail-hadoop-common-commits-archive@hadoop.apache.org Received: (qmail 49761 invoked by uid 500); 14 May 2015 08:48:41 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 49752 invoked by uid 99); 14 May 2015 08:48:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 08:48:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5E358E0978; Thu, 14 May 2015 08:48:41 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: vinayakumarb@apache.org To: common-commits@hadoop.apache.org Date: Thu, 14 May 2015 08:48:42 -0000 Message-Id: <4c3b51e16d404b73be9909196b495c97@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/2] hadoop git commit: HADOOP-8174. Remove confusing comment in Path#isAbsolute() (Contributed by Suresh Srinivas) HADOOP-8174. Remove confusing comment in Path#isAbsolute() (Contributed by Suresh Srinivas) (cherry picked from commit 0daa5ada68db483275aaa7f2ed9a2b5eaf5bb9bd) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/085841d9 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/085841d9 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/085841d9 Branch: refs/heads/branch-2 Commit: 085841d9ac7325a19a7db878654d331adae724c3 Parents: 4b5915b Author: Vinayakumar B Authored: Thu May 14 14:17:36 2015 +0530 Committer: Vinayakumar B Committed: Thu May 14 14:18:00 2015 +0530 ---------------------------------------------------------------------- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../src/main/java/org/apache/hadoop/fs/Path.java | 12 ++---------- 2 files changed, 5 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/085841d9/hadoop-common-project/hadoop-common/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 583db4c..e43540b 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -215,6 +215,9 @@ Release 2.8.0 - UNRELEASED HADOOP-11361. Fix a race condition in MetricsSourceAdapter.updateJmxCache. (Brahma Reddy Battula via ozawa) + HADOOP-8174. Remove confusing comment in Path#isAbsolute() + (Suresh Srinivas via vinayakumarb) + Release 2.7.1 - UNRELEASED INCOMPATIBLE CHANGES http://git-wip-us.apache.org/repos/asf/hadoop/blob/085841d9/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java index caeb7a1..a38a46c 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java @@ -31,8 +31,7 @@ import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.conf.Configuration; /** Names a file or directory in a {@link FileSystem}. - * Path strings use slash as the directory separator. A path string is - * absolute if it begins with a slash. + * Path strings use slash as the directory separator. */ @Stringable @InterfaceAudience.Public @@ -312,14 +311,7 @@ public class Path implements Comparable { return uri.getPath().startsWith(SEPARATOR, start); } - /** True if the path component of this URI is absolute. */ - /** - * There is some ambiguity here. An absolute path is a slash - * relative name without a scheme or an authority. - * So either this method was incorrectly named or its - * implementation is incorrect. This method returns true - * even if there is a scheme and authority. - */ + /** True if the path is not a relative path and starts with root. */ public boolean isAbsolute() { return isUriPathAbsolute(); }