hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiten...@apache.org
Subject [33/37] hadoop git commit: HADOOP-8174. Remove confusing comment in Path#isAbsolute() (Contributed by Suresh Srinivas)
Date Thu, 14 May 2015 20:12:34 GMT
HADOOP-8174. Remove confusing comment in Path#isAbsolute() (Contributed by Suresh Srinivas)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/0daa5ada
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/0daa5ada
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/0daa5ada

Branch: refs/heads/HDFS-7240
Commit: 0daa5ada68db483275aaa7f2ed9a2b5eaf5bb9bd
Parents: b2c85db
Author: Vinayakumar B <vinayakumarb@apache.org>
Authored: Thu May 14 14:17:36 2015 +0530
Committer: Vinayakumar B <vinayakumarb@apache.org>
Committed: Thu May 14 14:17:36 2015 +0530

----------------------------------------------------------------------
 hadoop-common-project/hadoop-common/CHANGES.txt         |  3 +++
 .../src/main/java/org/apache/hadoop/fs/Path.java        | 12 ++----------
 2 files changed, 5 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/0daa5ada/hadoop-common-project/hadoop-common/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 5e6b9ea..bf39c94 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -677,6 +677,9 @@ Release 2.8.0 - UNRELEASED
     HADOOP-11361. Fix a race condition in MetricsSourceAdapter.updateJmxCache.
     (Brahma Reddy Battula via ozawa)
 
+    HADOOP-8174. Remove confusing comment in Path#isAbsolute()
+    (Suresh Srinivas via vinayakumarb)
+
 Release 2.7.1 - UNRELEASED
 
   INCOMPATIBLE CHANGES

http://git-wip-us.apache.org/repos/asf/hadoop/blob/0daa5ada/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
index caeb7a1..a38a46c 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
@@ -31,8 +31,7 @@ import org.apache.hadoop.classification.InterfaceStability;
 import org.apache.hadoop.conf.Configuration;
 
 /** Names a file or directory in a {@link FileSystem}.
- * Path strings use slash as the directory separator.  A path string is
- * absolute if it begins with a slash.
+ * Path strings use slash as the directory separator.
  */
 @Stringable
 @InterfaceAudience.Public
@@ -312,14 +311,7 @@ public class Path implements Comparable {
     return uri.getPath().startsWith(SEPARATOR, start);
    }
   
-  /** True if the path component of this URI is absolute. */
-  /**
-   * There is some ambiguity here. An absolute path is a slash
-   * relative name without a scheme or an authority.
-   * So either this method was incorrectly named or its
-   * implementation is incorrect. This method returns true
-   * even if there is a scheme and authority.
-   */
+  /** True if the path is not a relative path and starts with root. */
   public boolean isAbsolute() {
      return isUriPathAbsolute();
   }


Mime
View raw message