hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From whe...@apache.org
Subject git commit: HADOOP-11193. Fix uninitialized variables in NativeIO.c. Contributed by Xiaoyu Yao.
Date Sat, 11 Oct 2014 06:02:33 GMT
Repository: hadoop
Updated Branches:
  refs/heads/trunk a5ec3d080 -> 554250cf8


HADOOP-11193. Fix uninitialized variables in NativeIO.c. Contributed by Xiaoyu Yao.


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/554250cf
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/554250cf
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/554250cf

Branch: refs/heads/trunk
Commit: 554250cf88aa0e4e69396b55773af4a9c09be143
Parents: a5ec3d0
Author: Haohui Mai <wheat9@apache.org>
Authored: Fri Oct 10 23:02:22 2014 -0700
Committer: Haohui Mai <wheat9@apache.org>
Committed: Fri Oct 10 23:02:22 2014 -0700

----------------------------------------------------------------------
 hadoop-common-project/hadoop-common/CHANGES.txt                  | 3 +++
 .../src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c | 2 +-
 .../hadoop-common/src/main/winutils/libwinutils.c                | 4 ++--
 3 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/554250cf/hadoop-common-project/hadoop-common/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 0e6f52b..b308f4e 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -827,6 +827,9 @@ Release 2.6.0 - UNRELEASED
     HADOOP-11133. Should trim the content of keystore password file for JavaKeyStoreProvider
     (Yi Liu via umamahesh)
 
+    HADOOP-11193. Fix uninitialized variables in NativeIO.c
+    (Xiaoyu Yao via wheat9)
+
     BREAKDOWN OF HDFS-6134 AND HADOOP-10150 SUBTASKS AND RELATED JIRAS
   
       HADOOP-10734. Implement high-performance secure random number sources.

http://git-wip-us.apache.org/repos/asf/hadoop/blob/554250cf/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
b/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
index d8538c8..b98aa0c 100644
--- a/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
+++ b/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
@@ -275,7 +275,7 @@ cleanup:
 #ifdef WINDOWS
   LPWSTR owner = NULL;
   LPWSTR group = NULL;
-  int mode;
+  int mode = 0;
   jstring jstr_owner = NULL;
   jstring jstr_group = NULL;
   int rc;

http://git-wip-us.apache.org/repos/asf/hadoop/blob/554250cf/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c b/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
index da16ff5..f275111 100644
--- a/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
+++ b/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
@@ -807,8 +807,8 @@ DWORD FindFileOwnerAndPermission(
   DWORD cbSid = SECURITY_MAX_SID_SIZE;
   PACL pDacl = NULL;
 
-  BOOL isSymlink;
-  BY_HANDLE_FILE_INFORMATION fileInformation;
+  BOOL isSymlink = FALSE;
+  BY_HANDLE_FILE_INFORMATION fileInformation = {0};
 
   ACCESS_MASK ownerAccessRights = 0;
   ACCESS_MASK groupAccessRights = 0;


Mime
View raw message