hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cmcc...@apache.org
Subject svn commit: r1502325 - /hadoop/common/trunk/dev-support/test-patch.sh
Date Thu, 11 Jul 2013 18:52:52 GMT
Author: cmccabe
Date: Thu Jul 11 18:52:52 2013
New Revision: 1502325

URL: http://svn.apache.org/r1502325
Log:
HADOOP-9186.  test-patch.sh should report build failure to JIRA.  (Binglin Chang via Colin
Patrick McCabe)

Modified:
    hadoop/common/trunk/dev-support/test-patch.sh

Modified: hadoop/common/trunk/dev-support/test-patch.sh
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/dev-support/test-patch.sh?rev=1502325&r1=1502324&r2=1502325&view=diff
==============================================================================
--- hadoop/common/trunk/dev-support/test-patch.sh (original)
+++ hadoop/common/trunk/dev-support/test-patch.sh Thu Jul 11 18:52:52 2013
@@ -266,7 +266,7 @@ verifyPatch () {
 }
 
 ###############################################################################
-buildWithPatch () {
+prebuildWithoutPatch () {
   echo ""
   echo ""
   echo "======================================================================"
@@ -283,7 +283,10 @@ buildWithPatch () {
     $MVN clean test -DskipTests > $PATCH_DIR/trunkCompile.txt 2>&1
     if [[ $? != 0 ]] ; then
       echo "Top-level trunk compilation is broken?"
-      cleanupAndExit 1
+      JIRA_COMMENT="$JIRA_COMMENT
+
+    {color:red}-1 patch{color}.  Top-level trunk compilation may be broken."
+      return 1
     fi
     cd -
   fi
@@ -292,8 +295,12 @@ buildWithPatch () {
   $MVN clean test -DskipTests -D${PROJECT_NAME}PatchProcess -Ptest-patch > $PATCH_DIR/trunkJavacWarnings.txt
2>&1
   if [[ $? != 0 ]] ; then
     echo "Trunk compilation is broken?"
-    cleanupAndExit 1
+    JIRA_COMMENT="$JIRA_COMMENT
+
+    {color:red}-1 patch{color}.  Trunk compilation may be broken."
+    return 1
   fi
+  return 0
 }
 
 ###############################################################################
@@ -954,7 +961,12 @@ if [[ $RESULT != 0 ]] ; then
   submitJiraComment 1
   cleanupAndExit 1
 fi
-buildWithPatch
+prebuildWithoutPatch
+(( RESULT = RESULT + $? ))
+if [[ $RESULT != 0 ]] ; then
+  submitJiraComment 1
+  cleanupAndExit 1
+fi
 checkAuthor
 (( RESULT = RESULT + $? ))
 



Mime
View raw message