hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject svn commit: r1485842 - in /hadoop/common/trunk/hadoop-common-project/hadoop-common: CHANGES.txt src/main/java/org/apache/hadoop/util/Shell.java
Date Thu, 23 May 2013 20:08:25 GMT
Author: stevel
Date: Thu May 23 20:08:25 2013
New Revision: 1485842

URL: http://svn.apache.org/r1485842
Log:
HADOOP-9593 stack trace printed at ERROR for all yarn clients without hadoop.home set

Modified:
    hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
    hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java

Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1485842&r1=1485841&r2=1485842&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt Thu May 23 20:08:25
2013
@@ -370,7 +370,10 @@ Trunk (Unreleased)
     HADOOP-9481. Broken conditional logic with HADOOP_SNAPPY_LIBRARY. (Vadim
     Bondarev via atm)
 
-  OPTIMIZATIONS
+    HADOOP-9593. stack trace printed at ERROR for all yarn clients without
+    hadoop.home set (stevel)
+
+    OPTIMIZATIONS
 
     HADOOP-7761. Improve the performance of raw comparisons. (todd)
 

Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java?rev=1485842&r1=1485841&r2=1485842&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
(original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
Thu May 23 20:08:25 2013
@@ -227,8 +227,10 @@ abstract public class Shell {
        home = homedir.getCanonicalPath();
 
     } catch (IOException ioe) {
-       LOG.error("Failed to detect a valid hadoop home directory", ioe);
-       home = null;
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Failed to detect a valid hadoop home directory", ioe);
+      }
+      home = null;
     }
     
     return home;
@@ -305,10 +307,13 @@ abstract public class Shell {
       shexec = new ShellCommandExecutor(args);
       shexec.execute();
     } catch (IOException ioe) {
-      LOG.warn("setsid is not available on this machine. So not using it.");
+      LOG.debug("setsid is not available on this machine. So not using it.");
       setsidSupported = false;
     } finally { // handle the exit code
-      LOG.info("setsid exited with exit code " + shexec.getExitCode());
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("setsid exited with exit code "
+                 + (shexec != null ? shexec.getExitCode() : "(null executor)"));
+      }
     }
     return setsidSupported;
   }



Mime
View raw message