hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sur...@apache.org
Subject svn commit: r1444418 - in /hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common: CHANGES.txt src/test/java/org/apache/hadoop/fs/TestListFiles.java src/test/java/org/apache/hadoop/tools/GetGroupsTestBase.java
Date Sat, 09 Feb 2013 20:09:21 GMT
Author: suresh
Date: Sat Feb  9 20:09:21 2013
New Revision: 1444418

URL: http://svn.apache.org/r1444418
Log:
Revering r1444416 because it committed unnecessary changes.

Modified:
    hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt
    hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestListFiles.java
    hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tools/GetGroupsTestBase.java

Modified: hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1444418&r1=1444417&r2=1444418&view=diff
==============================================================================
--- hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt Sat Feb
 9 20:09:21 2013
@@ -9,7 +9,6 @@ Release 2.0.4-beta - UNRELEASED
     HADOOP-9283. Add support for running the Hadoop client on AIX. (atm)
 
   IMPROVEMENTS
-
     HADOOP-9253. Capture ulimit info in the logs at service start time.
     (Arpit Gupta via suresh)
 
@@ -17,8 +16,6 @@ Release 2.0.4-beta - UNRELEASED
 
   BUG FIXES
 
-    HADOOP-9294. GetGroupsTestBase fails on Windows. (Chris Nauroth via suresh)
-
 Release 2.0.3-alpha - 2013-02-06 
 
   INCOMPATIBLE CHANGES

Modified: hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestListFiles.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestListFiles.java?rev=1444418&r1=1444417&r2=1444418&view=diff
==============================================================================
--- hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestListFiles.java
(original)
+++ hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestListFiles.java
Sat Feb  9 20:09:21 2013
@@ -45,39 +45,19 @@ public class TestListFiles {
 
   final protected static Configuration conf = new Configuration();
   protected static FileSystem fs;
-  protected static Path TEST_DIR;
+  final protected static Path TEST_DIR = getTestDir();
   final private static int FILE_LEN = 10;
-  private static Path FILE1;
-  private static Path DIR1;
-  private static Path FILE2;
-  private static Path FILE3;
-
-  static {
-    setTestPaths(new Path(
-      System.getProperty("test.build.data", "build/test/data/work-dir/localfs"),
-      "main_"));
-  }
+  final private static Path FILE1 = new Path(TEST_DIR, "file1");
+  final private static Path DIR1 = new Path(TEST_DIR, "dir1");
+  final private static Path FILE2 = new Path(DIR1, "file2");
+  final private static Path FILE3 = new Path(DIR1, "file3");
 
   protected static Path getTestDir() {
-    return TEST_DIR;
-  }
-
-  /**
-   * Sets the root testing directory and reinitializes any additional test paths
-   * that are under the root.  This method is intended to be called from a
-   * subclass's @BeforeClass method if there is a need to override the testing
-   * directory.
-   * 
-   * @param testDir Path root testing directory
-   */
-  protected static void setTestPaths(Path testDir) {
-    TEST_DIR = testDir;
-    FILE1 = new Path(TEST_DIR, "file1");
-    DIR1 = new Path(TEST_DIR, "dir1");
-    FILE2 = new Path(DIR1, "file2");
-    FILE3 = new Path(DIR1, "file3");
+    return new Path(
+      System.getProperty("test.build.data","build/test/data/work-dir/localfs"),
+      "main_");
   }
-
+  
   @BeforeClass
   public static void testSetUp() throws Exception {
     fs = FileSystem.getLocal(conf);

Modified: hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tools/GetGroupsTestBase.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tools/GetGroupsTestBase.java?rev=1444418&r1=1444417&r2=1444418&view=diff
==============================================================================
--- hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tools/GetGroupsTestBase.java
(original)
+++ hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tools/GetGroupsTestBase.java
Sat Feb  9 20:09:21 2013
@@ -108,7 +108,7 @@ public abstract class GetGroupsTestBase 
     for (String group : user.getGroupNames()) {
       expectedOutput += " " + group;
     }
-    return expectedOutput + System.getProperty("line.separator");
+    return expectedOutput + "\n";
   }
   
   private String runTool(Configuration conf, String[] args, boolean success)



Mime
View raw message