Return-Path: X-Original-To: apmail-hadoop-common-commits-archive@www.apache.org Delivered-To: apmail-hadoop-common-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1162BDFCF for ; Tue, 16 Oct 2012 16:53:28 +0000 (UTC) Received: (qmail 60537 invoked by uid 500); 16 Oct 2012 16:53:27 -0000 Delivered-To: apmail-hadoop-common-commits-archive@hadoop.apache.org Received: (qmail 60493 invoked by uid 500); 16 Oct 2012 16:53:27 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 60482 invoked by uid 99); 16 Oct 2012 16:53:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2012 16:53:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2012 16:53:26 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 709D523888E3; Tue, 16 Oct 2012 16:52:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1398883 - in /hadoop/common/trunk/hadoop-common-project/hadoop-common: CHANGES.txt src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java Date: Tue, 16 Oct 2012 16:52:43 -0000 To: common-commits@hadoop.apache.org From: suresh@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121016165243.709D523888E3@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: suresh Date: Tue Oct 16 16:52:42 2012 New Revision: 1398883 URL: http://svn.apache.org/viewvc?rev=1398883&view=rev Log: HADOOP-8923. JNI-based user-group mapping modules can be too chatty on lookup failures. Contributed by Kihwal Lee. Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1398883&r1=1398882&r2=1398883&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt Tue Oct 16 16:52:42 2012 @@ -1056,6 +1056,8 @@ Release 0.23.5 - UNRELEASED NEW FEATURES IMPROVEMENTS + HADOOP-8923. JNI-based user-group mapping modules can be too chatty on + lookup failures. (Kihwal Lee via suresh) OPTIMIZATIONS Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java?rev=1398883&r1=1398882&r2=1398883&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java Tue Oct 16 16:52:42 2012 @@ -48,7 +48,7 @@ public class JniBasedUnixGroupsMapping i throw new RuntimeException("Bailing out since native library couldn't " + "be loaded"); } - LOG.info("Using JniBasedUnixGroupsMapping for Group resolution"); + LOG.debug("Using JniBasedUnixGroupsMapping for Group resolution"); } @Override @@ -57,7 +57,11 @@ public class JniBasedUnixGroupsMapping i try { groups = getGroupForUser(user); } catch (Exception e) { - LOG.warn("Error getting groups for " + user, e); + if (LOG.isDebugEnabled()) { + LOG.debug("Error getting groups for " + user, e); + } else { + LOG.info("Error getting groups for " + user + ": " + e.getMessage()); + } } return Arrays.asList(groups); } Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java?rev=1398883&r1=1398882&r2=1398883&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java Tue Oct 16 16:52:42 2012 @@ -52,7 +52,7 @@ public class JniBasedUnixGroupsNetgroupM throw new RuntimeException("Bailing out since native library couldn't " + "be loaded"); } - LOG.info("Using JniBasedUnixGroupsNetgroupMapping for Netgroup resolution"); + LOG.debug("Using JniBasedUnixGroupsNetgroupMapping for Netgroup resolution"); } /** @@ -115,7 +115,12 @@ public class JniBasedUnixGroupsNetgroupM // JNI code does not expect '@' at the begining of the group name users = getUsersForNetgroupJNI(netgroup.substring(1)); } catch (Exception e) { - LOG.warn("error getting users for netgroup " + netgroup, e); + if (LOG.isDebugEnabled()) { + LOG.debug("Error getting users for netgroup " + netgroup, e); + } else { + LOG.info("Error getting users for netgroup " + netgroup + + ": " + e.getMessage()); + } } if (users != null && users.length != 0) { return Arrays.asList(users);