Return-Path: X-Original-To: apmail-hadoop-common-commits-archive@www.apache.org Delivered-To: apmail-hadoop-common-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B834E97A9 for ; Wed, 11 Jul 2012 06:44:01 +0000 (UTC) Received: (qmail 5967 invoked by uid 500); 11 Jul 2012 06:44:01 -0000 Delivered-To: apmail-hadoop-common-commits-archive@hadoop.apache.org Received: (qmail 5912 invoked by uid 500); 11 Jul 2012 06:44:00 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 5847 invoked by uid 99); 11 Jul 2012 06:43:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jul 2012 06:43:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jul 2012 06:43:57 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id D270F238899C for ; Wed, 11 Jul 2012 06:43:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1360035 - in /hadoop/common/branches/branch-1: CHANGES.txt src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Date: Wed, 11 Jul 2012 06:43:36 -0000 To: common-commits@hadoop.apache.org From: harsh@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120711064336.D270F238899C@eris.apache.org> Author: harsh Date: Wed Jul 11 06:43:36 2012 New Revision: 1360035 URL: http://svn.apache.org/viewvc?rev=1360035&view=rev Log: HDFS-3628. The dfsadmin -setBalancerBandwidth command on branch-1 does not check for superuser privileges. Contributed by Harsh J (harsh) Modified: hadoop/common/branches/branch-1/CHANGES.txt hadoop/common/branches/branch-1/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Modified: hadoop/common/branches/branch-1/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-1/CHANGES.txt?rev=1360035&r1=1360034&r2=1360035&view=diff ============================================================================== --- hadoop/common/branches/branch-1/CHANGES.txt (original) +++ hadoop/common/branches/branch-1/CHANGES.txt Wed Jul 11 06:43:36 2012 @@ -68,6 +68,9 @@ Release 1.2.0 - unreleased HDFS-2827. Cannot save namespace after renaming a directory above a file with an open lease. (Uma Maheswara Rao G via eli) + + HDFS-3628. The dfsadmin -setBalancerBandwidth command on branch-1 + does not check for superuser privileges. (harsh) Release 1.1.0 - unreleased Modified: hadoop/common/branches/branch-1/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-1/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java?rev=1360035&r1=1360034&r2=1360035&view=diff ============================================================================== --- hadoop/common/branches/branch-1/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (original) +++ hadoop/common/branches/branch-1/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Wed Jul 11 06:43:36 2012 @@ -723,6 +723,7 @@ public class FSNamesystem implements FSC * @throws IOException */ public void setBalancerBandwidth(long bandwidth) throws IOException { + checkSuperuserPrivilege(); synchronized(datanodeMap) { for (DatanodeDescriptor nodeInfo : datanodeMap.values()) { nodeInfo.setBalancerBandwidth(bandwidth);