hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Hadoop Wiki] Update of "HowToContribute" by MattFoley
Date Mon, 19 Sep 2011 17:58:28 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The "HowToContribute" page has been changed by MattFoley:
http://wiki.apache.org/hadoop/HowToContribute?action=diff&rev1=60&rev2=61

Comment:
Clarify submission process for non-trunk (sustaining) patches

  
  ==== Naming your patch ====
  
- Patches for trunk should be named '''jira-xyz.patch''', eg hdfs-123.patch. Patches for a
specific branch should be named '''jira-xyz-branch.patch''', eg hdfs-123-branch-0.20-security.
+ Patches for trunk should be named according to the Jira: '''jira-xyz.patch''', eg hdfs-1234.patch.

  
+ Patches for a non-trunk branch should be named '''jira-xyz-branch.patch''', eg hdfs-123-branch-0.20-security.patch.
 The branch name suffix should be the exact name of a Subversion branch under hadoop/common/branches/,
such as "branch-0.20-security".  This naming convention allows the pre-commit tests to automatically
run against the correct branch (new capability coming soon; see HADOOP-7435).
+ 
- It's OK to upload a patch to Jira with the same name as an existing patch, Jira will just
make the previous patches grey. They're still listed, sorted by date. If you select the "Activity>All"
tab then the different versions are linked in the comment stream, providing context. The branch
name allows the pre-commit tests to run against the correct branch (HADOOP-7435).
+ It's OK to upload a new patch to Jira with the same name as an existing patch, Jira will
just make the previous patches grey. They're still listed, sorted by date. If you select the
"Activity>All" tab then the different versions are linked in the comment stream, providing
context. 
  
  
  ==== Testing your patch ====
@@ -128, +130 @@

  dev-support/test-patch.sh /path/to/my.patch
  }}}
  
- At the end, you should get a message on your console that is similar to the comment added
to Jira by Jenkins's automated patch test system.  The scratch directory (which defaults to
the value of {{{${user.home}/tmp}}}) will contain some output files that will be useful in
determining what issues were found in the patch.
+ At the end, you should get a message on your console that is similar to the comment added
to Jira by Jenkins's automated patch test system, listing +1 and -1 results.  For non-trunk
patches (prior to HADOOP-7435 being implemented), please copy this results summary into the
Jira as a comment.  Generally you should expect a +1 overall in order to have your patch committed;
exceptions will be made for false positives that are unrelated to your patch.  The scratch
directory (which defaults to the value of {{{${user.home}/tmp}}}) will contain some output
files that will be useful in determining cause if issues were found in the patch.
  
  Some things to note:
  

Mime
View raw message