hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omal...@apache.org
Subject svn commit: r1077801 - in /hadoop/common/branches/branch-0.20-security-203: CHANGES.txt src/test/org/apache/hadoop/util/TestQueueProcessingStatistics.java
Date Fri, 04 Mar 2011 05:23:41 GMT
Author: omalley
Date: Fri Mar  4 05:23:41 2011
New Revision: 1077801

URL: http://svn.apache.org/viewvc?rev=1077801&view=rev
Log:
commit 170943b5880d588dd722b9640e52873cabf3a421
Author: Matt Foley <mattf@yahoo-inc.com>
Date:   Thu Feb 10 00:05:54 2011 -0800

    . Modified TestQueueProcessingStatistics to remove
    timing-sensitive statements in unit test.
    
    +++ b/YAHOO-CHANGES.txt
    +    . Add statistics logging to Fred for better visibility into
    +    startup time costs. (Matt Foley)  [modified per  to remove
    +    timing-sensitive statements in unit tests]
    +

Modified:
    hadoop/common/branches/branch-0.20-security-203/CHANGES.txt
    hadoop/common/branches/branch-0.20-security-203/src/test/org/apache/hadoop/util/TestQueueProcessingStatistics.java

Modified: hadoop/common/branches/branch-0.20-security-203/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-203/CHANGES.txt?rev=1077801&r1=1077800&r2=1077801&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security-203/CHANGES.txt (original)
+++ hadoop/common/branches/branch-0.20-security-203/CHANGES.txt Fri Mar  4 05:23:41 2011
@@ -2,11 +2,6 @@ Hadoop Change Log
 
 Release 0.20.3 - Unreleased
 
-  IMPROVEMENTS
-
-    BZ-4182948. Add statistics logging to Fred for better visibility into
-    startup time costs. (Matt Foley)
-
   BUG FIXES
 
     HDFS-955. New implementation of saveNamespace() to avoid loss of edits 

Modified: hadoop/common/branches/branch-0.20-security-203/src/test/org/apache/hadoop/util/TestQueueProcessingStatistics.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-203/src/test/org/apache/hadoop/util/TestQueueProcessingStatistics.java?rev=1077801&r1=1077800&r2=1077801&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security-203/src/test/org/apache/hadoop/util/TestQueueProcessingStatistics.java
(original)
+++ hadoop/common/branches/branch-0.20-security-203/src/test/org/apache/hadoop/util/TestQueueProcessingStatistics.java
Fri Mar  4 05:23:41 2011
@@ -89,6 +89,13 @@ public class TestQueueProcessingStatisti
     //Asserts based on general principles
     assertTrue(failMsg(), qStats.startTime >= 0);
     if (qStats.state != State.BEGIN_COLLECTING) {
+      /* The following timing calculations don't work in many 
+       * automated test environments (e.g., on heavily loaded servers with
+       * very unreliable "sleep()" durations), but are useful during 
+       * development work.  Commenting them out but leaving them here 
+       * for dev use.
+       */
+      /*
       assertAlmostEquals(failMsg() + " inCycle=" + inCycle, 
           qStats.startTimeCurrentCycle, 
           qStats.startTime 
@@ -100,6 +107,7 @@ public class TestQueueProcessingStatisti
           qStats.clockDuration, 
           qStats.processDuration 
           + cycleDelay * (qStats.cycleCount - (qStats.cycleCount > 0 ? 1 : 0)));
+       */
     }
     assertTrue(failMsg(), qStats.workItemCount >= 0);
     assertTrue(failMsg(), qStats.cycleCount >= 0);



Mime
View raw message