hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From e..@apache.org
Subject svn commit: r991821 - in /hadoop/common/trunk: CHANGES.txt src/test/core/org/apache/hadoop/io/TestBooleanWritable.java
Date Thu, 02 Sep 2010 06:26:44 GMT
Author: eli
Date: Thu Sep  2 06:26:43 2010
New Revision: 991821

URL: http://svn.apache.org/viewvc?rev=991821&view=rev
Log:
HADOOP-6934. Test for ByteWritable comparator. Contributed by Johannes Zillmann.

Added:
    hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java
Modified:
    hadoop/common/trunk/CHANGES.txt

Modified: hadoop/common/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/CHANGES.txt?rev=991821&r1=991820&r2=991821&view=diff
==============================================================================
--- hadoop/common/trunk/CHANGES.txt (original)
+++ hadoop/common/trunk/CHANGES.txt Thu Sep  2 06:26:43 2010
@@ -125,6 +125,9 @@ Trunk (unreleased changes)
     HADOOP-6803. Add native gzip read/write coverage to TestCodec.
     (Eli Collins via tomwhite)
 
+    HADOOP-6934. Test for ByteWritable comparator.
+    (Johannes Zillmann via Eli Collins)
+
   OPTIMIZATIONS
 
     HADOOP-6884. Add LOG.isDebugEnabled() guard for each LOG.debug(..).

Added: hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java?rev=991821&view=auto
==============================================================================
--- hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java (added)
+++ hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestBooleanWritable.java Thu Sep
 2 06:26:43 2010
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.io;
+
+import java.io.IOException;
+
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+public class TestBooleanWritable {
+
+  @Test
+  public void testCompareUnequalWritables() throws Exception {
+    DataOutputBuffer bTrue = writeWritable(new BooleanWritable(true));
+    DataOutputBuffer bFalse = writeWritable(new BooleanWritable(false));
+    WritableComparator writableComparator =
+      WritableComparator.get(BooleanWritable.class);
+
+    assertEquals(0, compare(writableComparator, bTrue, bTrue));
+    assertEquals(0, compare(writableComparator, bFalse, bFalse));
+    assertEquals(1, compare(writableComparator, bTrue, bFalse));
+    assertEquals(-1, compare(writableComparator, bFalse, bTrue));
+  }
+
+  private int compare(WritableComparator writableComparator,
+      DataOutputBuffer buf1, DataOutputBuffer buf2) {
+    return writableComparator.compare(buf1.getData(), 0, buf1.size(),
+        buf2.getData(), 0, buf2.size());
+  }
+
+  protected DataOutputBuffer writeWritable(Writable writable)
+      throws IOException {
+    DataOutputBuffer out = new DataOutputBuffer(1024);
+    writable.write(out);
+    out.flush();
+    return out;
+  }
+}



Mime
View raw message