hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Hadoop Wiki] Update of "Hbase/HowToContribute" by DanielPloeg
Date Wed, 26 May 2010 23:40:00 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The "Hbase/HowToContribute" page has been changed by DanielPloeg.
http://wiki.apache.org/hadoop/Hbase/HowToContribute?action=diff&rev1=15&rev2=16

--------------------------------------------------

  
  If you are an Eclipse user, you can apply a patch by : 1. Right click project name in Package
Explorer , 2. Team -> Apply Patch 
  
+ === Review Process ===
+ 
+ If you're patch contains more than 2 files that are changed and not yet had a review, please
submit to  [[http://review.hbase.org |Review Board]]. Some helpful hints for Review Board:
+  * Add the JIRA number to the Bugs field
+  * Use JIRA name and the short title for the "Summary" Field (eg: HBASE-1234 fix X Y Z)
+  * You will need to click on the Publish button after you make a change.
+  * Once changes are published, email will sent to the dev mailing list.
+  * Don't upload the patch to JIRA until the final version has completed review (ie JIRA
should contain only 1 patch that has been reviewed)
+  * Use the [[CodeReviewChecklist| code review checklist]] as a guide when doing reviews
+  * Reviewers can approve the patch by clicking on the "Ship it" option.
+  * Should your patch earn a -1 review, set the issue status to 'Resume Progress', upload
a patch to Review Board with necessary fixes and then set the status to 'Submit Patch' again.
+ 
+ 
  === Contributing your work ===
  
- Finally, patches should be ''attached'' to a bug report in [[https://issues.apache.org/jira/browse/HBASE|HBase
JIRA]] via the '''Attach File''' link on the jira. Please add a comment that asks for a code
review following our [[CodeReviewChecklist| code review checklist]]. Please note that the
attachment should be granted license to ASF for inclusion in ASF works (as per the [[http://www.apache.org/licenses/LICENSE-2.0|Apache
License]] §5). 
+ Patches should be ''attached'' to a bug report in [[https://issues.apache.org/jira/browse/HBASE|HBase
JIRA]] via the '''Attach File''' link on the jira. Please note that the attachment should
be granted license to ASF for inclusion in ASF works (as per the [[http://www.apache.org/licenses/LICENSE-2.0|Apache
License]] §5). 
  
+ When you believe that your patch is ready to be committed, select the 'Submit Patch' link
from the 'Available Workflow Actions' section in Jira. 
+ #Until there are automated Hudson patch builds, this will notify others that the patch is
ready to be reviewed.
- If you're patch contains more than 2 files that are changed, in addition to submitting the
patch to JIRA, please also submit to  [[http://review.hbase.org |Review Board]]. Reviewers
can examine and approve patches via the Review Board application.
- 
- When you believe that your patch is ready to be committed, select the 'Submit Patch' link
from the 'Available Workflow Actions' section in Jira. Until there are automated Hudson patch
builds, this will notify others that the patch is ready to be reviewed.
  
  ## The following section commented out until there are automated Hudson
  ## patch builds
@@ -189, +201 @@

  
  If your patch involves performance optimizations, they should be validated by benchmarks
that demonstrate an improvement.
  
- Once a "+1, code reviewed" comment is received from a code reviewer, a committer should
then evaluate it within a few days and either: commit it; or reject it with an explanation.
+ Once a "+1, code reviewed" comment or "Ship it" from Review Board is received from a code
reviewer, a committer should then evaluate it within a few days and either: commit it; or
reject it with an explanation.
  
  ## Once a "+1" comment is received from the automated patch testing system and a "+1, code
reviewed" comment is received from a code reviewer, a committer should then evaluate it within
a few days and either: commit it; or reject it with an explanation.
  
  Please be patient.  Committers are busy people too.  If no one responds to your patch after
a few days, please make friendly reminders.  Please incorporate other's suggestions into into
your patch if you think they're reasonable.  Finally, remember that even a patch that is not
committed is useful to the community.
  
- Should your patch earn a -1 review, set the issue status to 'Resume Progress', upload a
patch with necessary fixes and then set the status to 'Submit Patch' again.
+ 
  
  ## Should your patch earn a -1 on the Hudson test, set the issue status to 'Resume Progress',
upload a patch with necessary fixes and then set the status to 'Submit Patch' again.
  

Mime
View raw message