hadoop-common-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tomwh...@apache.org
Subject svn commit: r896691 - in /hadoop/common/trunk: CHANGES.txt src/test/core/org/apache/hadoop/io/TestUTF8.java
Date Wed, 06 Jan 2010 22:03:34 GMT
Author: tomwhite
Date: Wed Jan  6 22:03:33 2010
New Revision: 896691

URL: http://svn.apache.org/viewvc?rev=896691&view=rev
Log:
HADOOP-6479. TestUTF8 assertions could fail with better text. Contributed by Steve Loughran.

Modified:
    hadoop/common/trunk/CHANGES.txt
    hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java

Modified: hadoop/common/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/CHANGES.txt?rev=896691&r1=896690&r2=896691&view=diff
==============================================================================
--- hadoop/common/trunk/CHANGES.txt (original)
+++ hadoop/common/trunk/CHANGES.txt Wed Jan  6 22:03:33 2010
@@ -91,6 +91,9 @@
     HADOOP-3205. Read multiple chunks directly from FSInputChecker subclass
     into user buffers. (Todd Lipcon via tomwhite)
 
+    HADOOP-6479. TestUTF8 assertions could fail with better text.
+    (Steve Loughran via tomwhite)
+
   OPTIMIZATIONS
 
   BUG FIXES

Modified: hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java?rev=896691&r1=896690&r2=896691&view=diff
==============================================================================
--- hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java (original)
+++ hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java Wed Jan  6 22:03:33
2010
@@ -68,16 +68,16 @@
       // test that it reads correctly
       in.reset(out.getData(), out.getLength());
       String after = UTF8.readString(in);
-      assertTrue(before.equals(after));
+      assertEquals(before, after);
 
       // test that it reads correctly with DataInput
       in.reset(out.getData(), out.getLength());
       String after2 = in.readUTF();
-      assertTrue(before.equals(after2));
+      assertEquals(before, after2);
 
       // test that it is compatible with Java's other decoder
       String after3 = new String(out.getData(), 2, out.getLength()-2, "UTF-8");
-      assertTrue(before.equals(after3));
+      assertEquals(before, after3);
 
     }
 



Mime
View raw message