Return-Path: Delivered-To: apmail-hadoop-common-commits-archive@www.apache.org Received: (qmail 77094 invoked from network); 16 Nov 2009 06:56:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 16 Nov 2009 06:56:14 -0000 Received: (qmail 78344 invoked by uid 500); 16 Nov 2009 06:56:14 -0000 Delivered-To: apmail-hadoop-common-commits-archive@hadoop.apache.org Received: (qmail 78294 invoked by uid 500); 16 Nov 2009 06:56:13 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 78285 invoked by uid 99); 16 Nov 2009 06:56:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2009 06:56:12 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2009 06:56:10 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id D9C4523888D1; Mon, 16 Nov 2009 06:55:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r880632 - in /hadoop/common/branches/branch-0.20: CHANGES.txt src/c++/libhdfs/hdfs.c Date: Mon, 16 Nov 2009 06:55:43 -0000 To: common-commits@hadoop.apache.org From: dhruba@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091116065550.D9C4523888D1@eris.apache.org> Author: dhruba Date: Mon Nov 16 06:55:39 2009 New Revision: 880632 URL: http://svn.apache.org/viewvc?rev=880632&view=rev Log: HDFS-596. Fix memory leak in hdfsFreeFileInfo() for libhdfs. (Zhang Bingjun via dhruba) Modified: hadoop/common/branches/branch-0.20/CHANGES.txt hadoop/common/branches/branch-0.20/src/c++/libhdfs/hdfs.c Modified: hadoop/common/branches/branch-0.20/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20/CHANGES.txt?rev=880632&r1=880631&r2=880632&view=diff ============================================================================== --- hadoop/common/branches/branch-0.20/CHANGES.txt (original) +++ hadoop/common/branches/branch-0.20/CHANGES.txt Mon Nov 16 06:55:39 2009 @@ -63,6 +63,9 @@ MAPREDUCE-1068. Fix streaming job to show proper message if file is is not present. (Amareshwari Sriramadasu via sharad) + HDFS-596. Fix memory leak in hdfsFreeFileInfo() for libhdfs. + (Zhang Bingjun via dhruba) + Release 0.20.1 - 2009-09-01 INCOMPATIBLE CHANGES Modified: hadoop/common/branches/branch-0.20/src/c++/libhdfs/hdfs.c URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20/src/c%2B%2B/libhdfs/hdfs.c?rev=880632&r1=880631&r2=880632&view=diff ============================================================================== --- hadoop/common/branches/branch-0.20/src/c++/libhdfs/hdfs.c (original) +++ hadoop/common/branches/branch-0.20/src/c++/libhdfs/hdfs.c Mon Nov 16 06:55:39 2009 @@ -2071,12 +2071,18 @@ void hdfsFreeFileInfo(hdfsFileInfo *hdfsFileInfo, int numEntries) { - //Free the mName + //Free the mName, mOwner, and mGroup int i; for (i=0; i < numEntries; ++i) { if (hdfsFileInfo[i].mName) { free(hdfsFileInfo[i].mName); } + if (hdfsFileInfo[i].mOwner) { + free(hdfsFileInfo[i].mOwner); + } + if (hdfsFileInfo[i].mGroup) { + free(hdfsFileInfo[i].mGroup); + } } //Free entire block